You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (Commented) (JIRA)" <ji...@apache.org> on 2012/02/29 02:44:22 UTC

[jira] [Commented] (THRIFT-369) sets and maps break equality

    [ https://issues.apache.org/jira/browse/THRIFT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218819#comment-13218819 ] 

Hudson commented on THRIFT-369:
-------------------------------

Integrated in Thrift #415 (See [https://builds.apache.org/job/Thrift/415/])
    THRIFT-369: sets and maps break equality
Client: ruby
Patch: Ilya Maykov
Added a unit test demonstrating that equality is not broken for structs with nested containers. (Revision 1294917)

     Result = SUCCESS
ilyam : http://svn.apache.org/viewvc/?view=rev&rev=1294917
Files : 
* /thrift/trunk/lib/rb/spec/ThriftSpec.thrift
* /thrift/trunk/lib/rb/spec/struct_nested_containers_spec.rb

                
> sets and maps break equality
> ----------------------------
>
>                 Key: THRIFT-369
>                 URL: https://issues.apache.org/jira/browse/THRIFT-369
>             Project: Thrift
>          Issue Type: Bug
>          Components: Ruby - Library
>            Reporter: Bryan Duxbury
>            Assignee: Ilya Maykov
>            Priority: Minor
>             Fix For: 0.9
>
>         Attachments: THRIFT-369.patch
>
>
> I've found that two structs that have value-equivalent sets or maps as values for some reason cause struct's == to fail. This is inconsistent with other languages.
> For example, this struct: 
> {code}
> struct {
>   set_byte_map: <Set: { {1=>2} }>,
>   map_byte_map: { {1=>1} => 1 }
> }
> {code}
> created twice independently will not be ==.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira