You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:39:31 UTC

[GitHub] [incubator-nuttx] lukegluke commented on issue #1598: stm32f7 serial miss SERIAL_HAVE_CONSOLE_DMA definition

lukegluke commented on issue #1598:
URL: https://github.com/apache/incubator-nuttx/issues/1598#issuecomment-720551912


   Still an issues. But found out that issue is in stm32f7/stm32_serial.c
   https://github.com/apache/incubator-nuttx/blob/04ec9cf98960d6d6f3de50d67d4c53ce78bde3f5/arch/arm/src/stm32f7/stm32_serial.c#L3664
   
   Should be 
   #if defined(SERIAL_HAVE_CONSOLE_RXDMA) || defined(SERIAL_HAVE_CONSOLE_TXDMA)
   
   I missed that stm32f7/stm32_uart.h had already defines of two separate SERIAL_HAVE_CONSOLE_RXDMA, SERIAL_HAVE_CONSOLE_TXDMA added within your @davids5 commit baeaf54c6c3aa9371696a2012769403a9b169b50 but not used anywhere.
   https://github.com/apache/incubator-nuttx/blob/04ec9cf98960d6d6f3de50d67d4c53ce78bde3f5/arch/arm/src/stm32f7/stm32_uart.h#L269-L273
   https://github.com/apache/incubator-nuttx/blob/04ec9cf98960d6d6f3de50d67d4c53ce78bde3f5/arch/arm/src/stm32f7/stm32_uart.h#L290-L294


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org