You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2025/11/19 09:43:27 UTC

[I] Include "skip-ci" by default in m-release-p:prepare scmReleaseCommitComment [maven-release]

kwin opened a new issue, #1422:
URL: https://github.com/apache/maven-release/issues/1422

   ### New feature, improvement proposal
   
   The prepare goal adds two commits:
   1. With the release version
   2. With the next SNAPSHOT version
   
   Building 1. with regular CI often fails when it tries to deploy that (as it is not a SNAPSHOT).
   Therefore I propose to include a tag in the commit message which makes most CI system skip building it.
   
   That requires adjusting the default value for https://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#scmReleaseCommitComment
   
   The following commit messages are automatically skipped by
   - [GitHub Actions](https://docs.github.com/en/actions/how-tos/manage-workflow-runs/skip-workflow-runs)
   - [Jenkins SCM Skip Plugin](https://github.com/jenkinsci/scmskip-plugin/blob/master/README.md#release-notes)
   - [GitLab](https://docs.gitlab.com/ci/pipelines/#skip-a-pipeline)
   
   So I recommend including `[ci skip]` in the commit message by default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Include "[skip ci]" by default in m-release-p:prepare scmReleaseCommitComment [maven-release]

Posted by "nomis (via GitHub)" <gi...@apache.org>.
nomis commented on issue #1422:
URL: https://github.com/apache/maven-release/issues/1422#issuecomment-3612077119

   > 1. With the release version
   >
   > Building 1. with regular CI often fails when it tries to deploy that (as it is not a SNAPSHOT).
   
   This means that the configured CI build doesn't distinguish between snapshot and release builds. I may also fail to do this in pull requests and then depending on available permissions be a vulnerability allowing a third party contributor to deploy releases.
   
   > Therefore I propose to include a tag in the commit message which makes most CI system skip building it.
   
   The purpose of the CI build is to verify the software builds and although the commit is likely to only be to the version string, it should be built by CI. It's inappropriate to disable CI builds by default on what is the _released_ version of the software (i.e. the one build that it is most important that it's successful).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Include "[skip ci]" by default in m-release-p:prepare scmReleaseCommitComment [maven-release]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on issue #1422:
URL: https://github.com/apache/maven-release/issues/1422#issuecomment-3612429859

   > the commit is likely to only be to the version string
   
   This is not about likeliness, this is by definition only this as we are talking about a commit from m-release-p here. I would argue that
   - CI build before and after this commit is enough verification via CI IMHO
   - `m-release-p` both `prepare` and `perform` include a full build as well
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Include "[skip ci]" by default in m-release-p:prepare scmReleaseCommitComment [maven-release]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin closed issue #1422: Include "[skip ci]" by default in m-release-p:prepare scmReleaseCommitComment
URL: https://github.com/apache/maven-release/issues/1422


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Include "[skip ci]" by default in m-release-p:prepare scmReleaseCommitComment [maven-release]

Posted by "rvesse (via GitHub)" <gi...@apache.org>.
rvesse commented on issue #1422:
URL: https://github.com/apache/maven-release/issues/1422#issuecomment-3627281247

   As others already pointed out many developers/organisations trigger specific release workflows off the release tag so they don't want to skip CI for that as it's the commit that triggers actual release activities.
   
   You're free to run your CI/CD however you want but you should not be changing default configuration of a core Maven plugin in a way that enforces your CI/CD choices onto everyone else


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Include "[skip ci]" by default in m-release-p:prepare scmReleaseCommitComment [maven-release]

Posted by "rvesse (via GitHub)" <gi...@apache.org>.
rvesse commented on issue #1422:
URL: https://github.com/apache/maven-release/issues/1422#issuecomment-3627406529

   Opened #1445 to propose reverting this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Include "[skip ci]" by default in m-release-p:prepare scmReleaseCommitComment [maven-release]

Posted by "nomis (via GitHub)" <gi...@apache.org>.
nomis commented on issue #1422:
URL: https://github.com/apache/maven-release/issues/1422#issuecomment-3612576318

   >     * CI build before and after this commit is enough verification via CI IMHO
   
   No, anything could happen when the build runs with release version.
   
   >     * `m-release-p` both `prepare` and `perform` include a full build as well
   
   The purpose of the CI is to independently build the software and you're systematically skipping it for everyone by default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Include "[skip ci]" by default in m-release-p:prepare scmReleaseCommitComment [maven-release]

Posted by "rroesch1 (via GitHub)" <gi...@apache.org>.
rroesch1 commented on issue #1422:
URL: https://github.com/apache/maven-release/issues/1422#issuecomment-3617012615

   @kwin sorry, but this change is totally awkward 😠 
   Yes, there are two commits:
   * the commit for the next development version (this one is to be pushed to the branch)
   * the commit for the release version (this one is to be pushed to the tag)
   
   In a proper CI setups there are CI pipelines for both commits.
   i.e.:
   * one for the branch: this one is supposed the build and deploy the next SNAPSHOT
   * one for the tag: this one is supposed to build and deploy the new release
   
   I really do not get why the latter on should be disabled by default. 
   To me, this looks like a totally pointless change probably raising a lot of confusion and frustration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Include "[skip ci]" by default in m-release-p:prepare scmReleaseCommitComment [maven-release]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on issue #1422:
URL: https://github.com/apache/maven-release/issues/1422#issuecomment-3632904915

   This was reverted in https://github.com/apache/maven-release/commit/f0f28e5ac0f1fd017239484ad0605e74be194e2b.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org