You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/14 16:34:18 UTC

[GitHub] [arrow] westonpace commented on pull request #10025: ARROW-12379: [C++] Fix ThreadSanitizer failure in SerialExecutor

westonpace commented on pull request #10025:
URL: https://github.com/apache/arrow/pull/10025#issuecomment-819655814


   Thanks @pitrou .  A few thoughts (nothing worrisome):
   
   Why `deque` instead of `queue`?  I don't mind the change.  I just want to make sure I'm not missing some piece of knowledge.
   
   > Things may get tricky if cancellation or early exit is involved indeed...
   Cancellation should still flush the task queue.  Early exit (via bad `Status`) should still flush the task queue.  It is important we do because in both cases the remaining tasks might need to do some cleanup to handle the error.  Exceptions/assertions might not but we're already in crash territory there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org