You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by shawnfeldman <gi...@git.apache.org> on 2015/02/27 20:56:24 UTC
[GitHub] incubator-usergrid pull request: Usergrid 432: Add threads and cor...
GitHub user shawnfeldman opened a pull request:
https://github.com/apache/incubator-usergrid/pull/165
Usergrid 432: Add threads and cores back to pom.xml
had to account for null issues on deleting apps.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-usergrid USERGRID-432
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-usergrid/pull/165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #165
----
commit 7eb15afa65e21a044e500b0e13a4d1d968c3b225
Author: Shawn Feldman <sf...@apache.org>
Date: 2015-02-27T17:59:52Z
432: modify cores and add before shiro condition
commit 6273969d168a58d59d85f3797c3fdf40529f652d
Author: Shawn Feldman <sf...@apache.org>
Date: 2015-02-27T19:49:22Z
432: working with multithreaded builds
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 432: Add threads and cor...
Posted by tnine <gi...@git.apache.org>.
Github user tnine commented on a diff in the pull request:
https://github.com/apache/incubator-usergrid/pull/165#discussion_r25743827
--- Diff: stack/rest/src/main/java/org/apache/usergrid/rest/IndexResource.java ---
@@ -250,8 +250,10 @@ public JSONWithPadding addIndex(@Context UriInfo ui,
throw new IllegalArgumentException("Please add an indexSuffix to your post");
}
+ String writeConsistency = config.get("writeConsistency") != null ? (String)config.get("writeConsistency") : "one" ;
--- End diff --
Can we use IndexFig here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 432: Add threads and cor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-usergrid/pull/165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 432: Add threads and cor...
Posted by tnine <gi...@git.apache.org>.
Github user tnine commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/165#issuecomment-76743555
Just tried to test this before merging and I'm unable to get all the test to pass. @shawnfeldman Can you see if they run on your box?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 432: Add threads and cor...
Posted by tnine <gi...@git.apache.org>.
Github user tnine commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/165#issuecomment-76466886
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 432: Add threads and cor...
Posted by shawnfeldman <gi...@git.apache.org>.
Github user shawnfeldman commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/165#issuecomment-76983391
added async deltebyquery
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 432: Add threads and cor...
Posted by tnine <gi...@git.apache.org>.
Github user tnine commented on a diff in the pull request:
https://github.com/apache/incubator-usergrid/pull/165#discussion_r25743662
--- Diff: stack/core/src/main/java/org/apache/usergrid/corepersistence/CpWalker.java ---
@@ -58,8 +58,10 @@ public CpWalker(){
public void walkCollections(final CpEntityManager em, final EntityRef start,
String collectionName, boolean reverse, final CpVisitor visitor) throws Exception {
- doWalkCollections(
- em, collectionName, reverse, new SimpleId( start.getUuid(), start.getType() ), visitor );
+ if(start != null) {
--- End diff --
Should we fail silently or blow up here? Feels like we should do preconditions so we can flush out the incorrect caller impl
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 432: Add threads and cor...
Posted by tnine <gi...@git.apache.org>.
Github user tnine commented on a diff in the pull request:
https://github.com/apache/incubator-usergrid/pull/165#discussion_r25743611
--- Diff: stack/core/src/main/java/org/apache/usergrid/corepersistence/CpEntityManagerFactory.java ---
@@ -317,12 +317,11 @@ public void deleteApplication(UUID applicationId) throws Exception {
Query q = Query.fromQL(String.format("select * where applicationUuid = '%s'", applicationId.toString()));
Results results = em.searchCollection( em.getApplicationRef(), "appinfos", q);
Entity appToDelete = results.getEntity();
- em.delete( appToDelete );
-
- // create new Entity in deleted_appinfos collection, with same UUID and properties as deleted appinfo
- em.create( "deleted_appinfo", appToDelete.getProperties() );
-
- em.refreshIndex();
+ if(appToDelete != null) {
+ em.delete(appToDelete);
--- End diff --
We should reverse this. If the node dies after this call, we won't have marked it. Better to have an erroneous mark than to miss it completely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---