You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:28:03 UTC

[GitHub] [superset] rusackas opened a new issue #15127: [CRUD views]: empty state layout gets messed up when clicking sort headers on columns.

rusackas opened a new issue #15127:
URL: https://github.com/apache/superset/issues/15127


   ## Screenshot
   
   ![jitter](https://user-images.githubusercontent.com/812905/121754555-2a816c80-cad2-11eb-9b60-26e5634e8729.gif)
   
   ## Description
   
   When a CRUD view (e.g. Charts) is empty (which you can accomplish easily with filtering) the list area is short. If you click the sorting headers, you can see that the skeleton loader takes up a significant amount of real estate, which is weird. Also, the headers move around horizontally because of the skeleton loading display... bonus points awarded if the empty state column widths matched the loading state column widths.
   
   ## Design input
   [describe any input/collaboration you'd like from designers, and
   tag accordingly. For design review, add the
   label `design:review`. If this includes a design proposal,
   include the label `design:suggest`]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rusackas closed issue #15127: [CRUD views]: empty state layout gets messed up when clicking sort headers on columns.

Posted by GitBox <gi...@apache.org>.
rusackas closed issue #15127:
URL: https://github.com/apache/superset/issues/15127


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rusackas commented on issue #15127: [CRUD views]: empty state layout gets messed up when clicking sort headers on columns.

Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #15127:
URL: https://github.com/apache/superset/issues/15127#issuecomment-977267080


   Closed by https://github.com/apache/superset/pull/17515


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rusackas commented on issue #15127: [CRUD views]: empty state layout gets messed up when clicking sort headers on columns.

Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #15127:
URL: https://github.com/apache/superset/issues/15127#issuecomment-859941098


   Ugh... the screenshot doesn't show the gray background behind the empty state very well due to GIF dithering. You'll see it better when you try it yourself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org