[GitHub] [lucene-solr] uschindler commented on a change in pull request #1360: LUCENE-9281: Retire SPIClassIterator from master because Java 9+ uses different mechanism to load services when module system is used

[GitBox <gi...@apache.org>]

uschindler commented on a change in pull request #1360: LUCENE-9281: Retire SPIClassIterator from master because Java 9+ uses different mechanism to load services when module system is used
URL: https://github.com/apache/lucene-solr/pull/1360#discussion_r397955373
 
 

 ##########
 File path: lucene/CHANGES.txt
 ##########
 @@ -47,6 +47,13 @@ API Changes
 * LUCENE-9264: SimpleFSDirectory has been removed in favor of NIOFSDirectory.
   (Yannick Welsch)
 
+* LUCENE-9281: Use java.util.ServiceLoader to load codec components and analysis
+  factories to be compatible with Java Module System. This allows to load factories
+  without META-INF/service from a Java module exposing the factory in the module
+  descriptor. This breaks backwards compatibility as custom factories must now
+  also implement the default constructor (see MIGRATE.txt).
+  (Uwe Schindler, Dawid Weiss, Tomoko Uchida)
 
 Review comment:
   Removed you, I just added you because you were doing a lot of preparatory work and also commented on some changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org