You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Santhosh Kumar Shanmugham <sa...@gmail.com> on 2017/04/21 07:58:41 UTC
Review Request 58605: Default watch_secs to 0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58605/
-----------------------------------------------------------
Review request for Aurora, Stephan Erb and Zameer Manji.
Repository: aurora
Description
-------
Default watch_secs to 0.
Diffs
-----
src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8
src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928
Diff: https://reviews.apache.org/r/58605/diff/1/
Testing
-------
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 58605: Default watch_secs to 0.
Posted by Reza Motamedi via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58605/#review172674
-----------------------------------------------------------
Ship it!
Ship It!
- Reza Motamedi
On April 21, 2017, 4:32 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58605/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 4:32 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Default watch_secs to 0.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 1ee0d0167f0d212fa028f8ed0ddf20849703685c
> docs/reference/configuration.md 0040de17a85f5820c069474716678c66afce373b
> src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8
> src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928
>
>
> Diff: https://reviews.apache.org/r/58605/diff/2/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 58605: Default watch_secs to 0.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58605/#review172673
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On April 21, 2017, 6:32 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58605/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 6:32 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Default watch_secs to 0.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 1ee0d0167f0d212fa028f8ed0ddf20849703685c
> docs/reference/configuration.md 0040de17a85f5820c069474716678c66afce373b
> src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8
> src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928
>
>
> Diff: https://reviews.apache.org/r/58605/diff/2/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 58605: Default watch_secs to 0.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
> On April 21, 2017, 9:57 a.m., Aurora ReviewBot wrote:
> > Master (b847db8) is green with this patch.
> > ./build-support/jenkins/build.sh
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
We have decided that this patch is not necessary and might only cause unnecessary support work. Abandoning this patch.
- Santhosh Kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58605/#review172676
-----------------------------------------------------------
On April 21, 2017, 9:56 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58605/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 9:56 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Default watch_secs to 0.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 1ee0d0167f0d212fa028f8ed0ddf20849703685c
> docs/reference/configuration.md 0040de17a85f5820c069474716678c66afce373b
> src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8
> src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928
>
>
> Diff: https://reviews.apache.org/r/58605/diff/3/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 58605: Default watch_secs to 0.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58605/#review172676
-----------------------------------------------------------
Ship it!
Master (b847db8) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 21, 2017, 9:56 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58605/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 9:56 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Default watch_secs to 0.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 1ee0d0167f0d212fa028f8ed0ddf20849703685c
> docs/reference/configuration.md 0040de17a85f5820c069474716678c66afce373b
> src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8
> src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928
>
>
> Diff: https://reviews.apache.org/r/58605/diff/3/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 58605: Default watch_secs to 0.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58605/
-----------------------------------------------------------
(Updated April 21, 2017, 9:56 a.m.)
Review request for Aurora, Stephan Erb and Zameer Manji.
Changes
-------
Rebase.
Repository: aurora
Description
-------
Default watch_secs to 0.
Diffs (updated)
-----
RELEASE-NOTES.md 1ee0d0167f0d212fa028f8ed0ddf20849703685c
docs/reference/configuration.md 0040de17a85f5820c069474716678c66afce373b
src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8
src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928
Diff: https://reviews.apache.org/r/58605/diff/3/
Changes: https://reviews.apache.org/r/58605/diff/2-3/
Testing
-------
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 58605: Default watch_secs to 0.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58605/
-----------------------------------------------------------
(Updated April 21, 2017, 9:32 a.m.)
Review request for Aurora, Stephan Erb and Zameer Manji.
Changes
-------
Update docs and release notes.
Repository: aurora
Description
-------
Default watch_secs to 0.
Diffs (updated)
-----
RELEASE-NOTES.md 1ee0d0167f0d212fa028f8ed0ddf20849703685c
docs/reference/configuration.md 0040de17a85f5820c069474716678c66afce373b
src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8
src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928
Diff: https://reviews.apache.org/r/58605/diff/2/
Changes: https://reviews.apache.org/r/58605/diff/1-2/
Testing
-------
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 58605: Default watch_secs to 0.
Posted by Stephan Erb <se...@apache.org>.
> On April 21, 2017, 2:35 p.m., Aurora ReviewBot wrote:
> > Master (b847db8) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$8
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$7
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$9
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$4
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$3
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$6
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$5
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$2
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$1
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorageModule
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$SnapshotField
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/BackupModule
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery
> > Test coverage missing for org/apache/aurora/scheduler/TaskVars
> > Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
> > Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig
> > Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter
> > Test coverage missing for org/apache/aurora/scheduler/TaskVars$1
> > Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$TaskEventBatchWorker
> > Test coverage missing for org/apache/aurora/scheduler/HostOffer$1
> > Test coverage missing for org/apache/aurora/scheduler/SchedulerModule
> > Test coverage missing for org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl
> > Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$1
> > Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl
> > Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl$1
> > Test coverage missing for org/apache/aurora/scheduler/TierModule
> > Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
> >
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
> > ==============================================================================
> >
> > BUILD FAILED
> >
> > Total time: 15 mins 14.045 secs
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
The build failed with:
```
:pmdJmh
:pmdMain
:pmdTest
:test
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 343932928 bytes for committing reserved memory.
Java HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x00000007ab800000, 343932928, 0) failed; error='Cannot allocate memory' (errno=12)
# An error report file with more information is saved as:
# /home/jenkins/jenkins-slave/workspace/AuroraBot/hs_err_pid11675.log
Java HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x000000079b500000, 255328256, 0) failed; error='Cannot allocate memory' (errno=12)
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 255328256 bytes for committing reserved memory.
# An error report file with more information is saved as:
# /home/jenkins/jenkins-slave/workspace/AuroraBot/hs_err_pid11683.log
I0421 12:14:24.988 [ShutdownHook, SchedulerMain] Stopping scheduler services.
Could not stop org.gradle.internal.actor.internal.DefaultActorFactory$NonBlockingActor@467a8bc5.
org.gradle.internal.dispatch.DispatchException: Could not dispatch message [MethodInvocation method: stop()].
at org.gradle.internal.dispatch.ExceptionTrackingFailureHandler.dispatchFailed(ExceptionTrackingFailureHandler.java:34)
at org.gradle.internal.dispatch.FailureHandlingDispatch.dispatch(FailureHandlingDispatch.java:31)
at org.gradle.internal.dispatch.AsyncDispatch.dispatchMessages(AsyncDispatch.java:132)
at org.gradle.internal.dispatch.AsyncDispatch.access$000(AsyncDispatch.java:33)
at org.gradle.internal.dispatch.AsyncDispatch$1.run(AsyncDispatch.java:72)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.gradle.process.internal.ExecException: Process 'Gradle Test Executor 6' finished with non-zero exit value 1
at org.gradle.process.internal.DefaultExecHandle$ExecResultImpl.assertNormalExitValue(DefaultExecHandle.java:369)
at org.gradle.process.internal.worker.DefaultWorkerProcess.waitForStop(DefaultWorkerProcess.java:165)
at org.gradle.api.internal.tasks.testing.worker.ForkingTestClassProcessor.stop(ForkingTestClassProcessor.java:120)
at org.gradle.api.internal.tasks.testing.processors.RestartEveryNTestClassProcessor.endBatch(RestartEveryNTestClassProcessor.java:63)
at org.gradle.api.internal.tasks.testing.processors.RestartEveryNTestClassProcessor.stop(RestartEveryNTestClassProcessor.java:57)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.dispatch.FailureHandlingDispatch.dispatch(FailureHandlingDispatch.java:29)
... 8 more
Could not stop org.gradle.internal.actor.internal.DefaultActorFactory$NonBlockingActor@3c6cfd7.
org.gradle.internal.dispatch.DispatchException: Could not dispatch message [MethodInvocation method: stop()].
at org.gradle.internal.dispatch.ExceptionTrackingFailureHandler.dispatchFailed(ExceptionTrackingFailureHandler.java:34)
at org.gradle.internal.dispatch.FailureHandlingDispatch.dispatch(FailureHandlingDispatch.java:31)
at org.gradle.internal.dispatch.AsyncDispatch.dispatchMessages(AsyncDispatch.java:132)
at org.gradle.internal.dispatch.AsyncDispatch.access$000(AsyncDispatch.java:33)
at org.gradle.internal.dispatch.AsyncDispatch$1.run(AsyncDispatch.java:72)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.gradle.process.internal.ExecException: Process 'Gradle Test Executor 7' finished with non-zero exit value 1
at org.gradle.process.internal.DefaultExecHandle$ExecResultImpl.assertNormalExitValue(DefaultExecHandle.java:369)
at org.gradle.process.internal.worker.DefaultWorkerProcess.waitForStop(DefaultWorkerProcess.java:165)
at org.gradle.api.internal.tasks.testing.worker.ForkingTestClassProcessor.stop(ForkingTestClassProcessor.java:120)
at org.gradle.api.internal.tasks.testing.processors.RestartEveryNTestClassProcessor.endBatch(RestartEveryNTestClassProcessor.java:63)
at org.gradle.api.internal.tasks.testing.processors.RestartEveryNTestClassProcessor.stop(RestartEveryNTestClassProcessor.java:57)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.dispatch.FailureHandlingDispatch.dispatch(FailureHandlingDispatch.java:29)
... 8 more
:test FAILED
```
I managed to retrieve the full log and pasted it here: https://pastebin.com/JaXJ0YVY
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58605/#review172642
-----------------------------------------------------------
On April 21, 2017, 9:58 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58605/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 9:58 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Default watch_secs to 0.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8
> src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928
>
>
> Diff: https://reviews.apache.org/r/58605/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 58605: Default watch_secs to 0.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58605/#review172642
-----------------------------------------------------------
Master (b847db8) is red with this patch.
./build-support/jenkins/build.sh
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$8
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$7
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$9
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$4
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$3
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$6
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$5
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$2
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$1
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorageModule
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$SnapshotField
Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
Test coverage missing for org/apache/aurora/scheduler/storage/backup/BackupModule
Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl
Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery
Test coverage missing for org/apache/aurora/scheduler/TaskVars
Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig
Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter
Test coverage missing for org/apache/aurora/scheduler/TaskVars$1
Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$TaskEventBatchWorker
Test coverage missing for org/apache/aurora/scheduler/HostOffer$1
Test coverage missing for org/apache/aurora/scheduler/SchedulerModule
Test coverage missing for org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl
Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$1
Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl
Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl$1
Test coverage missing for org/apache/aurora/scheduler/TierModule
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 15 mins 14.045 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 21, 2017, 7:58 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58605/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 7:58 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Default watch_secs to 0.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8
> src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928
>
>
> Diff: https://reviews.apache.org/r/58605/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 58605: Default watch_secs to 0.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58605/#review172659
-----------------------------------------------------------
Ship it!
Master (b847db8) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 21, 2017, 7:58 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58605/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 7:58 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Default watch_secs to 0.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8
> src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928
>
>
> Diff: https://reviews.apache.org/r/58605/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 58605: Default watch_secs to 0.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58605/#review172658
-----------------------------------------------------------
@ReviewBot retry
- Stephan Erb
On April 21, 2017, 9:58 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58605/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 9:58 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Default watch_secs to 0.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8
> src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928
>
>
> Diff: https://reviews.apache.org/r/58605/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 58605: Default watch_secs to 0.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58605/#review172620
-----------------------------------------------------------
Please mention this in the changelog.
- Stephan Erb
On April 21, 2017, 9:58 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58605/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 9:58 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Default watch_secs to 0.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/schema/base.py b2692a648645a195a24491e4978fb833c6c20be8
> src/test/python/apache/aurora/client/cli/test_inspect.py 4a23c5984c2d093e2f53e93aec71418f84b65928
>
>
> Diff: https://reviews.apache.org/r/58605/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>