You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by ravicodder <gi...@git.apache.org> on 2016/02/03 06:48:42 UTC
[GitHub] incubator-zeppelin pull request: add new selenium test case for mo...
GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/687
add new selenium test case for move paragraph up and down
### What is this PR for?
Add new selenium test case for move paragraph up and down
### What type of PR is it?
Test
### Is there a relevant Jira issue?
NA
### How should this be tested?
On OSX, you'll need firefox 42.0 installed, then you can run with
PATH=~/Applications/Firefox.app/Contents/MacOS/:$PATH CI="" \
mvn -Dtest=org.apache.zeppelin.ParagraphActionsIT -Denforcer.skip=true \
test -pl zeppelin-server
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation?No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravicodder/incubator-zeppelin testMoveUpAndDown
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/687.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #687
----
commit 0b240e5c7fc0c4378c94e91122c7cd866b31a616
Author: Ravi Ranjan <ra...@gmail.com>
Date: 2016-02-03T05:31:56Z
add new test selenium case for move paragraph up and down
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add new selenium test case for mo...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/687#issuecomment-179733577
CI is green. Tested on my FF44.
LGTM !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add new selenium test case for mo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/687
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add new selenium test case for mo...
Posted by ravicodder <gi...@git.apache.org>.
Github user ravicodder commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/687#issuecomment-179032001
Job #2977.2 and #2977.4 are failing with non related issue details as follows:
Tests in error:
DepInterpreterTest.testDefault:96 » NullPointer
[INFO] Zeppelin: Spark .................................... FAILURE [01:33 min]
Ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add new selenium test case for mo...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/687#issuecomment-180531925
Great! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: add new selenium test case for mo...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/687#issuecomment-180880662
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---