[GitHub] [dolphinscheduler] stalary commented on a diff in pull request #11929: [Bug][Dependent]: Id also clone due to duplicate when use dependent mode.

[GitBox <gi...@apache.org>]

stalary commented on code in PR #11929:
URL: https://github.com/apache/dolphinscheduler/pull/11929#discussion_r970532625


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java:
##########
@@ -903,7 +903,8 @@ protected int createComplementDependentCommand(List<Schedule> schedules, Command
         List<DependentProcessDefinition> dependentProcessDefinitionList =
                 getComplementDependentDefinitionList(dependentCommand.getProcessDefinitionCode(),
                         CronUtils.getMaxCycle(schedules.get(0).getCrontab()), dependentCommand.getWorkerGroup());
-
+        // If the id is Integer, the auto-increment id will be obtained and cloned, causing duplicate writes

Review Comment:
   Before using int, mybtais-plus did not fill in the id field, it default use 0, but after being changed to Integer, it will fill it for auto-increment id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org