Re: [PR] refactor(ci): rely on pre-commit file arguments [iggy]

["hubcio (via GitHub)" <gi...@apache.org>]

hubcio commented on code in PR #3201:
URL: https://github.com/apache/iggy/pull/3201#discussion_r3194799339


##########
scripts/ci/taplo.sh:
##########
@@ -101,8 +92,13 @@ get_files() {
         # Generic CI - compare with HEAD~1
         git diff --name-only --diff-filter=ACM HEAD~1 -- '*.toml'
       else
-        # Fallback to staged files
-        git diff --cached --name-only --diff-filter=ACM -- '*.toml'
+        # Local fallback: check all TOML files
+        find . -name '*.toml' \

Review Comment:
   the local fallback here uses `find .` while the sibling scripts (`binary-artifacts.sh`, `trailing-newline.sh`, `trailing-whitespace.sh`) use `git ls-files` for the same fallback. inconsistent. could align to `git ls-files -- '*.toml'` and also collapse the duplication with the `all)` branch below since they're now functionally identical.



##########
scripts/ci/markdownlint.sh:
##########
@@ -34,19 +33,13 @@ while [[ $# -gt 0 ]]; do
       MODE="fix"
       shift
       ;;
-    --staged)
-      FILE_MODE="staged"
-      shift
-      ;;
     --all)
-      FILE_MODE="all"
       shift

Review Comment:
   `--all` is now a no-op (just `shift`, no `FILE_MODE` var anymore). help text on line 43 still says `(default)`. flag is harmless but redundant - either drop it or document it as accepted-for-compat.



##########
scripts/ci/shellcheck.sh:
##########
@@ -36,19 +35,13 @@ while [[ $# -gt 0 ]]; do
       MODE="fix"
       shift
       ;;
-    --staged)
-      FILE_MODE="staged"
-      shift
-      ;;
     --all)
-      FILE_MODE="all"
       shift

Review Comment:
   same as `markdownlint.sh` - `--all` is now a no-op after `FILE_MODE` removal. help text still claims it's the default. either drop the flag or keep it as a documented compat shim.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org