You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/10 14:04:43 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #9203: Make generated job_id more informative in BQ insert_job

mik-laj commented on a change in pull request #9203:
URL: https://github.com/apache/airflow/pull/9203#discussion_r438147912



##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -1636,6 +1636,7 @@ def execute(self, context: Any):
                 project_id=self.project_id,
                 location=self.location,
                 job_id=self.job_id,
+                _task_id=self.task_id

Review comment:
       Why are you passing task_id to the hook? I think it would be better if hook is not aware of the task.  You can generate a job ID and pass it as a parameter in the operator. Did I miss something?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org