You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by athanatos <gi...@git.apache.org> on 2017/06/15 17:50:04 UTC
[GitHub] bookkeeper pull request #193: BOOKKEEPER-1086: ZkUnderreplicationManager cac...
GitHub user athanatos opened a pull request:
https://github.com/apache/bookkeeper/pull/193
BOOKKEEPER-1086: ZkUnderreplicationManager cache watcher
Previously, getLedgerToReplicate left watches each time it traversed the
tree until it found a suitable replication target. Since we don't have
a way of canceling watches, these watches tended to get abandoned,
particularly on interior nodes, which aren't changed much. Thus,
over time, some nodes would build up a very large number of watch.
Instead, introduce a caching mechanism to remember outstanding watches
and avoid ever creating two watches on the same node.
Author: Samuel Just <sj...@salesforce.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/athanatos/bookkeeper forupstream/BOOKKEEPER-1098
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #193
----
commit cb3c7a2f4e256de00268740c37fc2a2ecd9b4e31
Author: Samuel Just <sj...@salesforce.com>
Date: 2017-03-29T19:06:56Z
BOOKKEEPER-1086: ZkUnderreplicationManager cache watcher
Previously, getLedgerToReplicate left watches each time it traversed the
tree until it found a suitable replication target. Since we don't have
a way of canceling watches, these watches tended to get abandoned,
particularly on interior nodes, which aren't changed much. Thus,
over time, some nodes would build up a very large number of watch.
Instead, introduce a caching mechanism to remember outstanding watches
and avoid ever creating two watches on the same node.
Author: Samuel Just <sj...@salesforce.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watc...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/193
@athanatos yeah, I just changed the title for the correct jira number.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #193: BOOKKEEPER-1086: ZkUnderreplicationManager cache watc...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/193
@athanatos can you change the title to "BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher"
our bot is binding comments to the wrong issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #193: BOOKKEEPER-1086: ZkUnderreplicationManager cache watc...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/193
@sijie I think this change can be merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper pull request #193: BOOKKEEPER-1086: ZkUnderreplicationManager cac...
Posted by sijie <gi...@git.apache.org>.
Github user sijie closed the pull request at:
https://github.com/apache/bookkeeper/pull/193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watc...
Posted by athanatos <gi...@git.apache.org>.
Github user athanatos commented on the issue:
https://github.com/apache/bookkeeper/pull/193
@sijie Oops, I just noticed the comments. I guess you just changed the title?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---