You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2017/10/20 14:05:43 UTC

[1/2] httpcomponents-stylecheck git commit: * Enforce declaration of parameter as final * Enforce declaration of enhanced for-loop variables as final * Require @Deprecated annotation for deprecated elements * Require @Override annotation for overridden m

Repository: httpcomponents-stylecheck
Updated Branches:
  refs/heads/master ee0812ae6 -> 87b1dd1e1


* Enforce declaration of parameter as final
* Enforce declaration of enhanced for-loop variables as final
* Require @Deprecated annotation for deprecated elements
* Require @Override annotation for overridden methods
* Disallow empty statements


Project: http://git-wip-us.apache.org/repos/asf/httpcomponents-stylecheck/repo
Commit: http://git-wip-us.apache.org/repos/asf/httpcomponents-stylecheck/commit/87b1dd1e
Tree: http://git-wip-us.apache.org/repos/asf/httpcomponents-stylecheck/tree/87b1dd1e
Diff: http://git-wip-us.apache.org/repos/asf/httpcomponents-stylecheck/diff/87b1dd1e

Branch: refs/heads/master
Commit: 87b1dd1e1108a5b72de02d7909f5b4e51b3b574a
Parents: ff2920f
Author: Oleg Kalnichevski <ol...@apache.org>
Authored: Fri Oct 20 15:58:53 2017 +0200
Committer: Oleg Kalnichevski <ol...@apache.org>
Committed: Fri Oct 20 16:05:13 2017 +0200

----------------------------------------------------------------------
 src/main/resources/hc-stylecheck/default.xml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/httpcomponents-stylecheck/blob/87b1dd1e/src/main/resources/hc-stylecheck/default.xml
----------------------------------------------------------------------
diff --git a/src/main/resources/hc-stylecheck/default.xml b/src/main/resources/hc-stylecheck/default.xml
index 11b852f..dd0b39b 100644
--- a/src/main/resources/hc-stylecheck/default.xml
+++ b/src/main/resources/hc-stylecheck/default.xml
@@ -29,7 +29,13 @@
     <module name="UnusedImports"/>
     <module name="EqualsHashCode"/>
     <module name="FinalParameters"/>
-    <module name="FinalLocalVariable"/>
+    <module name="FinalLocalVariable">
+      <property name="tokens" value="VARIABLE_DEF, PARAMETER_DEF"/>
+      <property name="validateEnhancedForLoopVariable" value="true"/>
+    </module>
+    <module name="MissingDeprecated"/>
+    <module name="MissingOverride"/>
+    <module name="EmptyStatement"/>
   </module>
   <module name="Header">
     <property name="headerFile" value="${checkstyle.header.file}" />


[2/2] httpcomponents-stylecheck git commit: Limit license header check to files with extension 'java'

Posted by ol...@apache.org.
Limit license header check to files with extension 'java'


Project: http://git-wip-us.apache.org/repos/asf/httpcomponents-stylecheck/repo
Commit: http://git-wip-us.apache.org/repos/asf/httpcomponents-stylecheck/commit/ff2920f6
Tree: http://git-wip-us.apache.org/repos/asf/httpcomponents-stylecheck/tree/ff2920f6
Diff: http://git-wip-us.apache.org/repos/asf/httpcomponents-stylecheck/diff/ff2920f6

Branch: refs/heads/master
Commit: ff2920f6eb9f5e217203613ebb265055b79a765a
Parents: ee0812a
Author: Oleg Kalnichevski <ol...@apache.org>
Authored: Fri Oct 20 15:45:08 2017 +0200
Committer: Oleg Kalnichevski <ol...@apache.org>
Committed: Fri Oct 20 16:05:13 2017 +0200

----------------------------------------------------------------------
 src/main/resources/hc-stylecheck/default.xml | 1 +
 src/main/resources/hc-stylecheck/minimal.xml | 1 +
 2 files changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/httpcomponents-stylecheck/blob/ff2920f6/src/main/resources/hc-stylecheck/default.xml
----------------------------------------------------------------------
diff --git a/src/main/resources/hc-stylecheck/default.xml b/src/main/resources/hc-stylecheck/default.xml
index 07e0031..11b852f 100644
--- a/src/main/resources/hc-stylecheck/default.xml
+++ b/src/main/resources/hc-stylecheck/default.xml
@@ -33,6 +33,7 @@
   </module>
   <module name="Header">
     <property name="headerFile" value="${checkstyle.header.file}" />
+    <property name="fileExtensions" value="java"/>
   </module>
   <module name="FileTabCharacter">
     <property name="eachLine" value="true"/>

http://git-wip-us.apache.org/repos/asf/httpcomponents-stylecheck/blob/ff2920f6/src/main/resources/hc-stylecheck/minimal.xml
----------------------------------------------------------------------
diff --git a/src/main/resources/hc-stylecheck/minimal.xml b/src/main/resources/hc-stylecheck/minimal.xml
index a879a0e..146c307 100644
--- a/src/main/resources/hc-stylecheck/minimal.xml
+++ b/src/main/resources/hc-stylecheck/minimal.xml
@@ -31,6 +31,7 @@
   </module>
   <module name="Header">
     <property name="headerFile" value="${checkstyle.header.file}" />
+    <property name="fileExtensions" value="java"/>
   </module>
   <module name="FileTabCharacter">
     <property name="eachLine" value="true"/>