[GitHub] [nutch] lewismc commented on a change in pull request #692: NUTCH-2885 Upgrade to Log4j2

[GitBox <gi...@apache.org>]

lewismc commented on a change in pull request #692:
URL: https://github.com/apache/nutch/pull/692#discussion_r681825788



##########
File path: ivy/ivy.xml
##########
@@ -36,14 +36,10 @@
 	</publications>
 
 	<dependencies>
-		<dependency org="org.slf4j" name="slf4j-api" rev="1.7.30" conf="*->master" />
-		<dependency org="org.slf4j" name="slf4j-log4j12" rev="1.7.30" conf="*->master" />
-
-		<!--dependency org="log4j" name="log4j" rev="1.2.15" conf="*->default">
-			<exclude org="javax.jms" name="jms" />
-			<exclude org="com.sun.jdmk" name="jmxtools" />
-			<exclude org="com.sun.jmx" name="jmxri" />
-		</dependency-->
+		<dependency org="org.apache.logging.log4j" name="log4j-api" rev="2.14.1" conf="*->master" />
+      <dependency org="org.apache.logging.log4j" name="log4j-core" rev="2.14.1" conf="*->master" />

Review comment:
       Good catch




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org