You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by calavera <gi...@git.apache.org> on 2016/05/05 22:13:46 UTC
[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...
GitHub user calavera opened a pull request:
https://github.com/apache/trafficserver/pull/618
[TS-4408] Make volume.config not order sensitive.
I added a couple of additional checks:
1. Fail with a format error if there are duplicated tokens, for instance:
volume=1 size=50% size=25%
2. Ignore everything else if there are other unknown tokens after parsing size and scheme:
volume=1 size=50% scheme=https foo=bar
Please, let me know if this is correct.
Signed-off-by: David Calavera <da...@gmail.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/calavera/trafficserver volume_tokens
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/618.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #618
----
commit 4a0727ac0195f0a0e449de0e96bf3d1efdf26c19
Author: David Calavera <da...@gmail.com>
Date: 2016-05-05T22:09:20Z
[TS-4408] Make volume.config not order sensitive.
Signed-off-by: David Calavera <da...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/618#issuecomment-219190138
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/618#issuecomment-218525599
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...
Posted by calavera <gi...@git.apache.org>.
Github user calavera commented on the pull request:
https://github.com/apache/trafficserver/pull/618#issuecomment-217479501
Thanks @jpeach. I'll look into that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/618#issuecomment-219194914
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/618#issuecomment-218782561
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #618: [TS-4408] Make volume.config not order sensitive.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/618
I did an initial review and some light testing of this.
@calavera the API I was referring to is ``parseConfigLine`` from ``MatcherUtils.cc``. It is not quite a generic parser but it will do the job here and tidy up a lot. I'm probably going to merge this as it, so we can make another PR for ``parseConfigLine``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/618#issuecomment-217472293
I haven't had time to look at this properly, but ``volume.config`` is not (only) parsed by the management routines, it is parsed by ``ConfigVolumes::BuildListFromString``. I am pretty sure that there are generic parsing routines for the key=value line format. I like the used of ``ink_atoi`` that you did here ... that's more convenient for the size field.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/618#issuecomment-217454573
Assigning to @PSUdaemon for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/618#issuecomment-220376299
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #618: [TS-4408] Make volume.config not order sens...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/618
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...
Posted by calavera <gi...@git.apache.org>.
Github user calavera commented on the pull request:
https://github.com/apache/trafficserver/pull/618#issuecomment-220679375
@jpeach I made some changes in ConfigVolumes::BuildListFromString to handle the un-ordered options too. I could not find those generic parsing routines but I can make the change if you point me to them
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #618: [TS-4408] Make volume.config not order sensitive.
Posted by calavera <gi...@git.apache.org>.
Github user calavera commented on the issue:
https://github.com/apache/trafficserver/pull/618
@jpeach sounds good to me. I can open a new pull request using that api.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/618#issuecomment-219186488
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/618#issuecomment-219191865
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---