You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2019/04/04 20:05:14 UTC
[kudu-CR] Enable tcmalloc heap sampling by default
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12933
Change subject: Enable tcmalloc heap sampling by default
......................................................................
Enable tcmalloc heap sampling by default
This enables tcmalloc heap sampling by default with
`--heap-sample-every-n-bytes` set to 512KiB. This will allow users to
use the `pprof` tool to gather tcmalloc heap profiles from running Kudu
processes, at the cost of some overheard in memory allocation. I've been
doing a lot of performance testing on a cluster with heap sampling
enabled at this frequency and I don't think the overhead is a problem.
Enabling this soon after the release of 1.9 gives us lots of time to run
this configuration in tests to see if it causes any problems.
Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9
---
M src/kudu/util/flags.cc
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/12933/1
--
To view, visit http://gerrit.cloudera.org:8080/12933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9
Gerrit-Change-Number: 12933
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] Enable tcmalloc heap sampling by default
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 )
Change subject: Enable tcmalloc heap sampling by default
......................................................................
Patch Set 1:
(1 comment)
> I vaguely remember this coming up before. Did we previously talk
> about enabling it by default?
Yes, I've mentioned that we should do it before, but this time I'm actually doing it :)
http://gerrit.cloudera.org:8080/#/c/12933/1/src/kudu/util/flags.cc
File src/kudu/util/flags.cc:
http://gerrit.cloudera.org:8080/#/c/12933/1/src/kudu/util/flags.cc@88
PS1, Line 88: DEFINE_int64(heap_sample_every_n_bytes, 524288,
> Nit: maybe change to 512 * 1024, and below don't bother talking about 52428
Done
--
To view, visit http://gerrit.cloudera.org:8080/12933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9
Gerrit-Change-Number: 12933
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 04 Apr 2019 20:14:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] Enable tcmalloc heap sampling by default
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed a vote on this change.
Change subject: Enable tcmalloc heap sampling by default
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9
Gerrit-Change-Number: 12933
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Enable tcmalloc heap sampling by default
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 )
Change subject: Enable tcmalloc heap sampling by default
......................................................................
Patch Set 2: Verified+1
The flake is KUDU-2564.
--
To view, visit http://gerrit.cloudera.org:8080/12933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9
Gerrit-Change-Number: 12933
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 04 Apr 2019 20:47:55 +0000
Gerrit-HasComments: No
[kudu-CR] Enable tcmalloc heap sampling by default
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 )
Change subject: Enable tcmalloc heap sampling by default
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9
Gerrit-Change-Number: 12933
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 04 Apr 2019 20:32:57 +0000
Gerrit-HasComments: No
[kudu-CR] Enable tcmalloc heap sampling by default
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 )
Change subject: Enable tcmalloc heap sampling by default
......................................................................
Patch Set 1: Code-Review+1
sgtm. We've had this on on a test cluster for probably a year now without any issues
--
To view, visit http://gerrit.cloudera.org:8080/12933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9
Gerrit-Change-Number: 12933
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 04 Apr 2019 20:11:30 +0000
Gerrit-HasComments: No
[kudu-CR] Enable tcmalloc heap sampling by default
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Mitch Barnett, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12933
to look at the new patch set (#2).
Change subject: Enable tcmalloc heap sampling by default
......................................................................
Enable tcmalloc heap sampling by default
This enables tcmalloc heap sampling by default with
`--heap-sample-every-n-bytes` set to 512KiB. This will allow users to
use the `pprof` tool to gather tcmalloc heap profiles from running Kudu
processes, at the cost of some overheard in memory allocation. I've been
doing a lot of performance testing on a cluster with heap sampling
enabled at this frequency and I don't think the overhead is a problem.
Enabling this soon after the release of 1.9 gives us lots of time to run
this configuration in tests to see if it causes any problems.
Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9
---
M src/kudu/util/flags.cc
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/12933/2
--
To view, visit http://gerrit.cloudera.org:8080/12933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9
Gerrit-Change-Number: 12933
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Enable tcmalloc heap sampling by default
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 )
Change subject: Enable tcmalloc heap sampling by default
......................................................................
Patch Set 1:
(1 comment)
I vaguely remember this coming up before. Did we previously talk about enabling it by default?
http://gerrit.cloudera.org:8080/#/c/12933/1/src/kudu/util/flags.cc
File src/kudu/util/flags.cc:
http://gerrit.cloudera.org:8080/#/c/12933/1/src/kudu/util/flags.cc@88
PS1, Line 88: DEFINE_int64(heap_sample_every_n_bytes, 524288,
Nit: maybe change to 512 * 1024, and below don't bother talking about 524288 but just 512 KB?
--
To view, visit http://gerrit.cloudera.org:8080/12933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9
Gerrit-Change-Number: 12933
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 04 Apr 2019 20:08:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] Enable tcmalloc heap sampling by default
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12933 )
Change subject: Enable tcmalloc heap sampling by default
......................................................................
Enable tcmalloc heap sampling by default
This enables tcmalloc heap sampling by default with
`--heap-sample-every-n-bytes` set to 512KiB. This will allow users to
use the `pprof` tool to gather tcmalloc heap profiles from running Kudu
processes, at the cost of some overheard in memory allocation. I've been
doing a lot of performance testing on a cluster with heap sampling
enabled at this frequency and I don't think the overhead is a problem.
Enabling this soon after the release of 1.9 gives us lots of time to run
this configuration in tests to see if it causes any problems.
Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9
Reviewed-on: http://gerrit.cloudera.org:8080/12933
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/util/flags.cc
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Will Berkeley: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9
Gerrit-Change-Number: 12933
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>