You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "dominikriemer (via GitHub)" <gi...@apache.org> on 2024/08/08 15:47:11 UTC
[PR] feat(#3114): Improve pipeline details view
dominikriemer opened a new pull request, #3115:
URL: https://github.com/apache/streampipes/pull/3115
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
<!--
Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
1. If this is your first time, please read our contributor guidelines:
- https://streampipes.apache.org/community/get-involved/
- https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
2. Make sure the PR title is formatted like: `[#<GitHub issue id>] PR title ...`
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][#<GitHub issue id>] PR title ...`.
4. Please write your PR title to summarize what this PR proposes/fixes.
5. Link the PR to the corresponding GitHub issue (if present) in the `Development` section in the right menu bar.
6. Be sure to keep the PR description updated to reflect all changes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
8. Make sure tests pass via `mvn clean install`.
9. (Optional) If the contribution is large, please file an Apache ICLA
- http://apache.org/licenses/icla.pdf
-->
### Purpose
<!--
Please clarify what changes you are proposing and describe how those changes will address the issue.
Furthermore, describe potential consequences the changes might have.
-->
See #3114
### Remarks
<!--
Is there anything left we need to pay attention on?
Are there some references that might be important? E.g. links to Confluence, or discussions
on the mailing list or GitHub.
-->
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(#3114): Improve pipeline details view
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on code in PR #3115:
URL: https://github.com/apache/streampipes/pull/3115#discussion_r1710837179
##########
ui/src/app/pipelines/pipelines.module.ts:
##########
Review Comment:
Should we move the routes for the pipeline details to the 'Pipeline Details' module. So that we have a single point where we can see which components of a module are exposed via routes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(#3114): Improve pipeline details view
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on PR #3115:
URL: https://github.com/apache/streampipes/pull/3115#issuecomment-2277272280
I tried the "Refresh metrics" button, but the metrics were not updated.
How often are the metrics updated? The "Auto refresh" button triggers the "/metrics" endpoint, but the values don't change often.
From a user's perspective, this could be unexpected, what do you think?
<img width="1506" alt="grafik" src="https://github.com/user-attachments/assets/1598bafc-41f4-41b0-b34a-501f1533ba6d">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(#3114): Improve pipeline details view
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on PR #3115:
URL: https://github.com/apache/streampipes/pull/3115#issuecomment-2277855287
Thanks Philipp for your feedback.
I plan two push two more PRs related to the pipeline view (cleanup of the editor components and preview in the details view), I'll address your comments in these two PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(#3114): Improve pipeline details view
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on PR #3115:
URL: https://github.com/apache/streampipes/pull/3115#issuecomment-2277233011
`pipeline-details.routes.ts` seems not to be used anywhere. Can it be deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(#3114): Improve pipeline details view
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer merged PR #3115:
URL: https://github.com/apache/streampipes/pull/3115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org