You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2020/06/22 08:06:18 UTC

[GitHub] [curator] eolivelli commented on pull request #367: CURATOR-574 DiscoveryService fatal error on deserializing an empty byte[] as JSON

eolivelli commented on pull request #367:
URL: https://github.com/apache/curator/pull/367#issuecomment-647356586


   @Randgalt 
   the patch is finally ready for review.
   I have added a few assertions on an existing test.
   
   With this fix the errors on CURATOR-574 are not present anymore.
   I wonder if it is better to rename the issue, actually this was a problem on PathChildrenCacheListenerWrapper.java and not in ServiceDiscovery.
   
   The change is not backward compatibile, but it is on a fresh new API of Curator 5.0, so if you release 5.0.1 (or 5.1 if you want to strictly observe SemVer) it won't be a big deal
   
   I can create the 5.0.1 release


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org