[GitHub] [pinot] walterddr commented on a diff in pull request #9711: [multistage] partial operator chain execution

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9711:
URL: https://github.com/apache/pinot/pull/9711#discussion_r1012454160


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -116,6 +119,11 @@ public String toExplainString() {
   protected TransferableBlock getNextBlock() {
     try {
       consumeInputBlocks();
+
+      if (!_readyToConstruct) {
+        return TransferableBlockUtils.getNoOpTransferableBlock();
+      }
+
       return produceAggregatedBlock();

Review Comment:
   wondering if we can wrapped around these with a BaseTransferrableOperator than handles metadata block (NOOP, ERROR, not sure if possible for EOS)



##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryDispatcher.java:
##########
@@ -137,25 +137,31 @@ public static List<DataTable> reduceMailboxReceive(MailboxReceiveOperator mailbo
           throw new RuntimeException("Received error query execution result block: "
               + transferableBlock.getDataBlock().getExceptions());
       }
+      if (transferableBlock.isNoOpBlock()) {
+        continue;
+      } else if (transferableBlock.isEndOfStreamBlock()) {
+        return resultDataBlocks;
+      }

Review Comment:
   these should be after null check?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org