You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2017/11/05 12:41:16 UTC

[GitHub] storm pull request #2401: STORM-2799: Exclude jdk.tools for JDK 9 compatibil...

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2401

    STORM-2799: Exclude jdk.tools for JDK 9 compatibility

    See https://issues.apache.org/jira/browse/STORM-2799.
    
    This excludes jdk.tools from a few dependencies. I also upgraded hbase to the latest patch release of the current version, since the 1.1.0 version leaks jdk.tools https://issues.apache.org/jira/browse/HBASE-13963 and versions prior to 1.1.11 don't work with Java 9 https://issues.apache.org/jira/browse/HBASE-17944. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-2799

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2401.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2401
    
----
commit b37d31a0240b4f3b64d5b74025a1649224eeb794
Author: Stig Rohde Døssing <sr...@apache.org>
Date:   2017-11-04T21:24:58Z

    STORM-2799: Exclude jdk.tools for JDK 9 compatibility

----


---

[GitHub] storm issue #2401: STORM-2799: Exclude jdk.tools for JDK 9 compatibility

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2401
  
    The test failure seems unrelated. I've run the tests a few times on JDK 8 and haven't been able to reproduce the failure.  


---

[GitHub] storm pull request #2401: STORM-2799: Exclude jdk.tools for JDK 9 compatibil...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2401


---

[GitHub] storm issue #2401: STORM-2799: Exclude jdk.tools for JDK 9 compatibility

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on the issue:

    https://github.com/apache/storm/pull/2401
  
    The changes look fine, but the test failure is something I have been seeing quite a bit recently, but only on travis.  I think it must be a race condition.  I am going to file a JIRA for it, but I have no idea when I will have time to look into it.


---