[GitHub] [airflow] FloChehab edited a comment on pull request #10584: Add support for envFrom in helm chart

[GitBox <gi...@apache.org>]

FloChehab edited a comment on pull request #10584:
URL: https://github.com/apache/airflow/pull/10584#issuecomment-682585084


   Hi @dimberman, I just tested with the kubernetes executor. Everything looks good to me ; the "automated" injection for Secrets / ConfigMaps works as expected. There is just one weird thing going on (not related to this PR I think): Secrets get included twice (only once, as execpected, for the CMs).
   
   For instance if in the scheduler pod we have:
   ```yaml
   env:
       - name: AIRFLOW__KUBERNETES__ENV_FROM_SECRET_REF
         value: mysecret,mysecret2
       - name: AIRFLOW__KUBERNETES__ENV_FROM_CONFIGMAP_REF
         value: test-airflow,test-airflow2
   ```
   
   In the pod created by the executor, I have:
   ```yaml
       envFrom:
       - configMapRef:
           name: test-airflow
       - configMapRef:
           name: test-airflow2
       - secretRef:
           name: mysecret
       - secretRef:
           name: mysecret2
       - secretRef:
           name: mysecret
       - secretRef:
           name: mysecret2
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org