[jira] [Updated] (HIVE-15833) Add unit tests for org.json usage on branch-1

["Daniel Voros (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-15833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Voros updated HIVE-15833:
--------------------------------
    Attachment: HIVE-15833.1-branch-1.patch

Attaching patch #1. This adds test to all non-trivial usages of the org.json library.

The new tests also use org.json, but only to a minimal extent and only where it is necessary to interact with the units under tests (e.g. when testing a method with a JSONObject attribute). These usages should be trivial to replace when switching implementation.

In every other place, where org.json was not absolutely necessary, Jackson is used to interact with (mostly to compare) JSON objects. Jackson was chosen over json-simple and gson, as it is already a dependency of Hive and it's object mapping capabilities might come in handy when switching implementation.

> Add unit tests for org.json usage on branch-1
> ---------------------------------------------
>
>                 Key: HIVE-15833
>                 URL: https://issues.apache.org/jira/browse/HIVE-15833
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Daniel Voros
>            Assignee: Daniel Voros
>             Fix For: 2.2.0
>
>         Attachments: HIVE-15833.1-branch-1.patch
>
>
> Before switching implementation, we should add some tests that capture the current behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)