[PATCH] improve logging of errors under mod_dav_svn

[Garrett Rooney <ro...@electricjellyfish.net>]

So while debugging a DAV problem recently I noticed that mod_dav_svn
isn't all that good about logging errors.  Specifically,
dav_svn_convert_error has this way of taking the top error in a chain,
logging it, and forgetting about all the rest of the underlying
errors.  This is kind of silly, since the mod_dav error infrastructure
actually has the same kind of chain of errors functionality that we
have in our svn_error_t stuff.

This is issue #2482, for the curious.

Anyway, I took a look at this today, and came up with a patch to fix
it.  It just builds up a chain of DAV errors to correspond to the
chain of svn errors that are passed to dav_svn_convert_error.  If
someone with some DAV background could take a look at it, I'd
appreciate it.

-garrett

[[[
Make mod_dav_svn log all the errors in a given chain, rather than just the
topmost one.  This fixes issue #2482.

* subversion/mod_dav_svn/util.c
  (dav_svn_convert_error): Use build_error_chain to create our dav error.
  (build_error_chain): New helper function that recursively builds a chain
   of dav_error objects based on a svn_error_t.
]]]

Re: [PATCH] improve logging of errors under mod_dav_svn

[Garrett Rooney <ro...@electricjellyfish.net>]

On 1/23/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> So while debugging a DAV problem recently I noticed that mod_dav_svn
> isn't all that good about logging errors.  Specifically,
> dav_svn_convert_error has this way of taking the top error in a chain,
> logging it, and forgetting about all the rest of the underlying
> errors.  This is kind of silly, since the mod_dav error infrastructure
> actually has the same kind of chain of errors functionality that we
> have in our svn_error_t stuff.
>
> This is issue #2482, for the curious.
>
> Anyway, I took a look at this today, and came up with a patch to fix
> it.  It just builds up a chain of DAV errors to correspond to the
> chain of svn errors that are passed to dav_svn_convert_error.  If
> someone with some DAV background could take a look at it, I'd
> appreciate it.

A slightly modified version of this (thanks to dlr's review) was
committed in r18211.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org