You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "rykovsi (via GitHub)" <gi...@apache.org> on 2023/09/25 11:53:11 UTC

[GitHub] [kafka] rykovsi opened a new pull request, #14441: Correct SslPrincipalMapper.java

rykovsi opened a new pull request, #14441:
URL: https://github.com/apache/kafka/pull/14441

   Correct this "&" to "&&"
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mimaison merged pull request #14441: KAFKA-15500: Correct SslPrincipalMapper.java

Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #14441:
URL: https://github.com/apache/kafka/pull/14441


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] divijvaidya commented on pull request #14441: KAFKA-15500: Correct SslPrincipalMapper.java

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #14441:
URL: https://github.com/apache/kafka/pull/14441#issuecomment-1740767993

   > In this case `&` is treated as logical AND. I think the only difference with `&&` is that `&` always executes the right side expression even if the left side expression is false. So in this case I'm not sure you can write a test that differentiates `&` and `&&`.
   
   You are right. I was mistaken in thinking that this is a bug. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] divijvaidya commented on pull request #14441: [KAFKA-15500] Correct SslPrincipalMapper.java

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #14441:
URL: https://github.com/apache/kafka/pull/14441#issuecomment-1740643148

   Thank you submitting this fix @rykovsi. I was wondering if we could add a unit test in `SslPrincipalMapperTest` that would fail with the bug and pass after this is fixed. It would help us detect such bugs in future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mimaison commented on pull request #14441: KAFKA-15500: Correct SslPrincipalMapper.java

Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #14441:
URL: https://github.com/apache/kafka/pull/14441#issuecomment-1740654238

   In this case `&` is treated as logical AND. I think the only difference with `&&` is that `&`  always executes the right side expression even if the left side expression is false. So in this case I'm not sure you can write a test that differentiates `&` and `&&`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org