You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/17 07:53:00 UTC
[GitHub] [incubator-kyuubi] lightning-L opened a new pull request, #3256: [KYUUBI #3251] fix thrift http frontend connection metrics
lightning-L opened a new pull request, #3256:
URL: https://github.com/apache/incubator-kyuubi/pull/3256
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3256: [KYUUBI #3251] Fix thrift http frontend connection metrics
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3256:
URL: https://github.com/apache/incubator-kyuubi/pull/3256#discussion_r947638446
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/operation/thrift/http/KyuubiOperationThriftHttpPerUserSuite.scala:
##########
@@ -34,5 +37,42 @@ class KyuubiOperationThriftHttpPerUserSuite extends KyuubiOperationPerUserSuite
s"jdbc:hive2://${server.frontendServices.head.connectionUrl}/;transportMode=http;" +
s"httpPath=cliservice;"
- override protected lazy val httpMode = true;
+ override protected lazy val httpMode = true
+
+ test("test connection metric") {
+ val totalConnections =
+ MetricsSystem.counterValue(MetricsConstants.THRIFT_HTTP_CONN_TOTAL).getOrElse(0L)
+ val openConnections =
+ MetricsSystem.counterValue(MetricsConstants.THRIFT_HTTP_CONN_OPEN).getOrElse(0L)
+ val failedConnections =
+ MetricsSystem.counterValue(MetricsConstants.THRIFT_HTTP_CONN_FAIL).getOrElse(0L)
+
+ withJdbcStatement() { _ =>
+ assert(MetricsSystem.counterValue(
+ MetricsConstants.THRIFT_HTTP_CONN_TOTAL).getOrElse(0L) - totalConnections === 1)
+ assert(MetricsSystem.counterValue(
+ MetricsConstants.THRIFT_HTTP_CONN_OPEN).getOrElse(0L) - openConnections === 1)
+ assert(MetricsSystem.counterValue(
+ MetricsConstants.THRIFT_HTTP_CONN_FAIL).getOrElse(0L) - failedConnections === 0)
+
+ withJdbcStatement() { _ =>
+ assert(MetricsSystem.counterValue(
+ MetricsConstants.THRIFT_HTTP_CONN_TOTAL).getOrElse(0L) - totalConnections === 2)
+ assert(MetricsSystem.counterValue(
+ MetricsConstants.THRIFT_HTTP_CONN_OPEN).getOrElse(0L) - openConnections === 2)
+ assert(MetricsSystem.counterValue(
+ MetricsConstants.THRIFT_HTTP_CONN_FAIL).getOrElse(0L) - failedConnections === 0)
+ }
+
+ }
+
+ eventually(timeout(1.seconds), interval(200.milliseconds)) {
+ assert(MetricsSystem.counterValue(
Review Comment:
```
- test connection metric *** FAILED ***
The code passed to eventually never returned normally. Attempted 15 times over 1.0059717080000001 seconds. Last failure message: 2 did not equal 0. (KyuubiOperationThriftHttpPerUserSuite.scala:69)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] github-actions[bot] commented on pull request #3256: [KYUUBI #3251] Fix thrift http frontend connection metrics
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3256:
URL: https://github.com/apache/incubator-kyuubi/pull/3256#issuecomment-1328139279
Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!
Thank you for using Kyuubi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3256: [KYUUBI #3251] fix thrift http frontend connection metrics
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3256:
URL: https://github.com/apache/incubator-kyuubi/pull/3256#discussion_r947582970
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/operation/thrift/http/KyuubiOperationThriftHttpPerUserSuite.scala:
##########
@@ -34,5 +37,42 @@ class KyuubiOperationThriftHttpPerUserSuite extends KyuubiOperationPerUserSuite
s"jdbc:hive2://${server.frontendServices.head.connectionUrl}/;transportMode=http;" +
s"httpPath=cliservice;"
- override protected lazy val httpMode = true;
+ override protected lazy val httpMode = true
+
+ test("test connection metric") {
Review Comment:
nit: `thrift http connection metrics`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] github-actions[bot] closed pull request #3256: [KYUUBI #3251] Fix thrift http frontend connection metrics
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3256: [KYUUBI #3251] Fix thrift http frontend connection metrics
URL: https://github.com/apache/incubator-kyuubi/pull/3256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] lightning-L commented on pull request #3256: [KYUUBI #3251] fix thrift http frontend connection metrics
Posted by GitBox <gi...@apache.org>.
lightning-L commented on PR #3256:
URL: https://github.com/apache/incubator-kyuubi/pull/3256#issuecomment-1217629693
Reference: https://github.com/apache/hive/blob/9ad5a0b28b136521ded27b4b5418f61b610da788/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org