You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2013/03/14 18:48:28 UTC
Re: Review Request: OOZIE-1234: JMS Event Listeners for publishing
notifications related to workflow and coordinator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9622/#review17885
-----------------------------------------------------------
just small note, message(i.e. CoordinatorActionFailureMessage) refer to following,
>import org.apache.oozie.client.event.Event.EventStatus;
>import org.apache.oozie.client.event.Event.EventType;
but currently Event is under core module, not client, not good idea to keep it in two places, probably we should keep Event under client, only.
- Ryota Egashira
On Feb. 26, 2013, 6:39 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9622/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2013, 6:39 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> Description at https://issues.apache.org/jira/browse/OOZIE-1234
>
> OOZIE-1209 generates events and handles them by calling appropriate listeners. This patch provides JMS implementation of those listeners. Also, the messages are serialized using JSON and there is a deserializer to construct the Java object back from json.
>
>
> This addresses bug OOZIE-1234.
> https://issues.apache.org/jira/browse/OOZIE-1234
>
>
> Diffs
> -----
>
> trunk/client/pom.xml 1450312
> trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMSMessagingUtils.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMS_HEADER_CONSTANTS.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/messaging/CoordinatorActionFailureMessage.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/messaging/CoordinatorActionMessage.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/messaging/CoordinatorActionStartedMessage.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/messaging/CoordinatorActionSuccessMessage.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/messaging/CoordinatorActionWaitingMessage.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/messaging/EventMessage.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/messaging/WorkflowJobFailureMessage.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/messaging/WorkflowJobMessage.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/messaging/WorkflowJobStartedMessage.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/messaging/WorkflowJobSuccessMessage.java PRE-CREATION
> trunk/core/pom.xml 1450312
> trunk/core/src/main/java/org/apache/oozie/event/messaging/JSONMessageSerializer.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageSerializer.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java 1450312
> trunk/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java 1450312
> trunk/core/src/main/java/org/apache/oozie/jms/JMSCoordEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java 1450312
> trunk/core/src/main/java/org/apache/oozie/jms/JMSWorkflowEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1450312
> trunk/core/src/test/java/org/apache/oozie/jms/TestJMSCoordinatorEventListener.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/jms/TestJMSWorkflowEventListener.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 1450312
>
> Diff: https://reviews.apache.org/r/9622/diff/
>
>
> Testing
> -------
>
> Unit test cases added. Test case for JMS connection failure pending. End to end test pending
>
>
> Thanks,
>
> Virag Kothari
>
>