You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by jreichhold <gi...@git.apache.org> on 2014/05/21 01:17:27 UTC
[GitHub] incubator-storm pull request: Allow parsing of String into int for...
GitHub user jreichhold opened a pull request:
https://github.com/apache/incubator-storm/pull/119
Allow parsing of String into int for command line flags
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jreichhold/incubator-storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/119.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #119
----
commit 5ae9c09d8f9e6f20ef85968f2efcbee702d6ebdf
Author: Jonathan Reichhold <jo...@usermind.com>
Date: 2014-05-20T23:16:19Z
Allow parsing of String into int for command line flags
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Allow parsing of String into int for...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/incubator-storm/pull/119#issuecomment-53524483
@jreichhold could you please open a JIRA and do an up merge of your changes. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Allow parsing of String into int for...
Posted by nathanmarz <gi...@git.apache.org>.
Github user nathanmarz commented on the pull request:
https://github.com/apache/incubator-storm/pull/119#issuecomment-53525133
This patch also needs to have all the formatting changes taken out so that it's clean.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Allow parsing of String into int for...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/119#issuecomment-46431279
Looks like this is related to STORM-72. @jreichhold should I reopen STORM-72 for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Allow parsing of String into int for...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/119#issuecomment-45949135
@jreichhold, Could you file a JIRA for this pull request, and then include `[STORM-XXX]` in the title? (Replace `XXX` with the new JIRA number.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Allow parsing of String into int for...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/incubator-storm/pull/119#issuecomment-52247921
@jreichhold, Since `getInt(Object o)` now relies of `getInt(Object o, Integer defaultValue)` to determine action by the `instanceof o`, parsing `int` out of `string` would have to move to that function. Please update the pull request accordingly.
Also, please create a separate jira for this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---