You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/10/31 14:14:00 UTC
[jira] [Commented] (KNOX-2979) Remove redundant 'refresh' query parameter from logout.jsp
[ https://issues.apache.org/jira/browse/KNOX-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781379#comment-17781379 ]
ASF subversion and git services commented on KNOX-2979:
-------------------------------------------------------
Commit d569373582b800c6c0346cb25e5fe5ec06054050 in knox's branch refs/heads/master from Sandor Molnar
[ https://gitbox.apache.org/repos/asf?p=knox.git;h=d56937358 ]
KNOX-2979 - Removed redundant 'refresh' query parameter from the application logout link after originalUrl (#815)
> Remove redundant 'refresh' query parameter from logout.jsp
> ----------------------------------------------------------
>
> Key: KNOX-2979
> URL: https://issues.apache.org/jira/browse/KNOX-2979
> Project: Apache Knox
> Issue Type: Task
> Components: Homepage, KnoxSSO
> Affects Versions: 2.0.0, 1.6.0, 1.6.1
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Critical
> Fix For: 2.1.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> KNOX-2625 introduced a new query parameter called {{refresh}} which is only used in the Knox Home page UI's {{handleError}} method. Because of the way, how Angular renders pages after issuing a {{sweetalert}} notification, which we do, followed by a {{{}Promise.reject(String){}}}, the {{refresh}} query parameter is redundant and not needed at all.
> Even worse, it might interfere with the profile/topology query parameters we added in KNOX-2972 in a way such that the topologies will not be displayed.
> Therefore, removing the {{refresh}} query parameter in the logout link is highly recommended.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)