You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/04/06 17:33:37 UTC
[GitHub] [activemq-artemis] franz1981 opened a new pull request #3068:
ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order
sensitive
franz1981 opened a new pull request #3068: ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order sensitive
URL: https://github.com/apache/activemq-artemis/pull/3068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 edited a comment on issue #3068:
ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order
sensitive
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on issue #3068: ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order sensitive
URL: https://github.com/apache/activemq-artemis/pull/3068#issuecomment-609935465
I still need to validate the behavior at an higher level of abstraction ie
- ServerConnectVoteHandler unit test
- with an end 2 end test
And run the whole test suite to see if this isn't causing regressions (especially on `QuorumVoteServerConnect::await` that doesn't have any test coverage and I'm not sure of the original semantic of it). Probably it can create issues on the live when `vote-on-replication-failure` is set and we're awaiting the votes to complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #3068: ARTEMIS-2702
QuorumVoteServerConnect with requestToStayLive is voting order sensitive
Posted by GitBox <gi...@apache.org>.
franz1981 commented on issue #3068: ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order sensitive
URL: https://github.com/apache/activemq-artemis/pull/3068#issuecomment-610240422
I've decided to merge the 2 commits into one, hardening the expected behaviour after solving some test failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 edited a comment on issue #3068:
ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order
sensitive
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on issue #3068: ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order sensitive
URL: https://github.com/apache/activemq-artemis/pull/3068#issuecomment-609951227
I've sent a second commit that (assuming that I've correctly understood the original logic) simplify the current logic. @clebertsuconic @jbertram @andytaylor please take a look at the 2 commits separately, if I've misunderstood how `QuorumVoteServerConnect` is supposed to work...
In addition: I see that we should check for `targetNodeId` vs `ServerConnectVote::getNodeId` on `QuorumVoteServerConnect::vote` too (probably).
Let's see if it breaks any existing test...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 edited a comment on issue #3068:
ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order
sensitive
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on issue #3068: ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order sensitive
URL: https://github.com/apache/activemq-artemis/pull/3068#issuecomment-609951227
I've sent a second commit that (assuming that I've correctly understood the original logic) simplify the current logic. @clebertsuconic @jbertram @andytaylor please take a look at the 2 commits separately, if I've misunderstood how `QuorumVoteServerConnect` is supposed to work...
In addition: I see that we should check for `targetNodeId` vs `ServerConnectVote::getNodeId` on `QuorumVoteServerConnect::vote` too (probably).
`QuorumFailOverTest::testQuorumVotingLiveNotDead` is failing with this, so probably there is something in the original logic that I haven't honored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #3068: ARTEMIS-2702
QuorumVoteServerConnect with requestToStayLive is voting order sensitive
Posted by GitBox <gi...@apache.org>.
franz1981 commented on issue #3068: ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order sensitive
URL: https://github.com/apache/activemq-artemis/pull/3068#issuecomment-609951227
I've sent a second commit that (assuming that I've correctly understood the original logic) simplify the current logic. @clebertsuconic @jbertram @andytaylor please take a look at the 2 commits separately, if I've misunderstood how `QuorumVoteServerConnect` is supposed to work...
In addition: I see that we should check for `targetNodeId` vs `ServerConnectVote::getNodeId` on `QuorumVoteServerConnect::vote` too (probably).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #3068: ARTEMIS-2702
QuorumVoteServerConnect with requestToStayLive is voting order sensitive
Posted by GitBox <gi...@apache.org>.
franz1981 commented on issue #3068: ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order sensitive
URL: https://github.com/apache/activemq-artemis/pull/3068#issuecomment-609935465
I still need to validate the behavior at an higher level of abstraction ie
- ServerConnectVoteHandler unit test
- with an end 2 end test
And run the whole test suite to see if this isn't causing regressions (especially on `QuorumVoteServerConnect::await` that doesn't have any test coverage and I'm not sure of the original semantic. Probably it can create issues on the live when `vote-on-replication-failure` is set and we're awaiting the votes to complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #3068: ARTEMIS-2702
QuorumVoteServerConnect with requestToStayLive is voting order sensitive
Posted by GitBox <gi...@apache.org>.
franz1981 commented on issue #3068: ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order sensitive
URL: https://github.com/apache/activemq-artemis/pull/3068#issuecomment-610388803
I need to take care of a couple of log messages on the test and It seems ok (looking at the CI test too)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #3068: ARTEMIS-2702
QuorumVoteServerConnect with requestToStayLive is voting order sensitive
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3068: ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order sensitive
URL: https://github.com/apache/activemq-artemis/pull/3068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services