[jira] [Commented] (AIRFLOW-3602) Change ImapHook to raise an Exception when no attachments have been found

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739647#comment-16739647 ] 

ASF GitHub Bot commented on AIRFLOW-3602:
-----------------------------------------

feluelle commented on pull request #4475: [AIRFLOW-3602] Changes ImapHook to raise an exception on no attachments
URL: https://github.com/apache/airflow/pull/4475
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   This PR changes the ImapHook so it will fail when no attachments have been found.
   It also:
   - fixes escaping chars and symlink tests not testing correctly
   - adds note for handling symlinks
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Change ImapHook to raise an Exception when no attachments have been found
> -------------------------------------------------------------------------
>
>                 Key: AIRFLOW-3602
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3602
>             Project: Apache Airflow
>          Issue Type: Improvement
>    Affects Versions: 1.10.1
>            Reporter: Felix Uellendall
>            Assignee: Felix Uellendall
>            Priority: Major
>
> At the moment the
> {code:python}
> def retrieve_mail_attachments(self, name, mail_folder='INBOX', check_regex=False,
>                                   latest_only=False):
> {code}
> returns an empty list if no attachments have been found.
> And the
> {code:python}
> def download_mail_attachments(self, name, local_output_directory, mail_folder='INBOX',
>                                   check_regex=False, latest_only=False):
> {code}
> also does not log anything if no attachment has been found.
> Is this useful? Or would it be better to raise an exception instead?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)