[GitHub] [calcite] rubenada commented on a change in pull request #1303: [CALCITE-3170] ANTI join on conditions push down generates wrong plan

[GitBox <gi...@apache.org>]

rubenada commented on a change in pull request #1303: [CALCITE-3170] ANTI join on conditions push down generates wrong plan
URL: https://github.com/apache/calcite/pull/1303#discussion_r300959765
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
 ##########
 @@ -414,6 +415,82 @@ protected DiffRepository getDiffRepos() {
         .check();
   }
 
+  /** Test case for
+   * <a href="https://issues.apache.org/jira/browse/CALCITE-3170">[CALCITE-3170]
+   * ANTI join on conditions push down generates wrong plan</a>. */
+  @Test public void testCanNotPushAntiJoinConditionsToLeft() {
+    final RelBuilder relBuilder = RelBuilder.create(RelBuilderTest.config().build());
+    // build a rel equivalent to sql:
+    // select * from emp
+    // where emp.empno
 
 Review comment:
   minor: SQL description does not correspond to relBuilder expression:
   where emp.**deptno** 
   not in (select dept.deptno from dept where emp.deptno > 20)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services