You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Jacques Le Roux (Jira)" <ji...@apache.org> on 2024/03/05 15:11:00 UTC
[jira] [Commented] (OFBIZ-12778) Tidy up PDF accounting reports
[ https://issues.apache.org/jira/browse/OFBIZ-12778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823666#comment-17823666 ]
Jacques Le Roux commented on OFBIZ-12778:
-----------------------------------------
Hi Daniel,
While at your request trying to test for OFBIZ-12127 I stumbled upon an issue I don't reproduce on stable demo.
It's about example/control/ExampleReportPdfOptions?exampleId=EX01 when using the "View as spreadsheet" feature. I get this locally:
{noformat}
2024-03-05 15:42:44,583 |jsse-nio-8443-exec-1 |FreeMarkerWorker |E| null
freemarker.core._MiscTemplateException: Macro "renderSubmitField" has no parameter with name "closeOnSubmit". Valid parameter names are: buttonType, className, alert, formName, action, imgSrc, ajaxUrl, id, title, name, event, confirmatio
n, containerId, tabindex, disabled
----
FTL stack trace ("~" means nesting-related):
- Failed at: @renderSubmitField buttonType="button... [in template "eb356d72-2329-45d8-893e-9b8d89d2b2ee" at line 1, column 1]
----
at freemarker.core.Environment.newUndeclaredParamNameException(Environment.java:1143) ~[freemarker-2.3.32.jar:2.3.32]
at freemarker.core.Environment.setMacroContextLocalsFromArguments(Environment.java:1023) ~[freemarker-2.3.32.jar:2.3.32]
at freemarker.core.Environment.invokeMacroOrFunctionCommonPart(Environment.java:859) ~[freemarker-2.3.32.jar:2.3.32]
at freemarker.core.Environment.invokeMacro(Environment.java:813) [freemarker-2.3.32.jar:2.3.32]
at freemarker.core.UnifiedCall.accept(UnifiedCall.java:84) ~[freemarker-2.3.32.jar:2.3.32]
at freemarker.core.Environment.visit(Environment.java:335) [freemarker-2.3.32.jar:2.3.32]
at freemarker.core.Environment.include(Environment.java:3104) [freemarker-2.3.32.jar:2.3.32]
at org.apache.ofbiz.widget.renderer.macro.FtlWriter.processFtlString(FtlWriter.java:87) [main/:?]
at org.apache.ofbiz.widget.renderer.macro.MacroFormRenderer.executeMacro(MacroFormRenderer.java:152) [main/:?]
at org.apache.ofbiz.widget.renderer.macro.MacroFormRenderer.renderSubmitField(MacroFormRenderer.java:530) [main/:?]
at org.apache.ofbiz.widget.model.ModelFormField$SubmitField.renderFieldString(ModelFormField.java:5059) [main/:?]
at org.apache.ofbiz.widget.model.ModelFormField.renderFieldString(ModelFormField.java:812) [main/:?]
at org.apache.ofbiz.widget.renderer.FormRenderer.renderSingleFormString(FormRenderer.java:1208) [main/:?]
at org.apache.ofbiz.widget.renderer.FormRenderer.render(FormRenderer.java:288) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:1098) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:947) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:142) [main/:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
at freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1553) [freemarker-2.3.32.jar:2.3.32]
at freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:73) [freemarker-2.3.32.jar:2.3.32]
at freemarker.core.MethodCall._eval(MethodCall.java:62) [freemarker-2.3.32.jar:2.3.32]
at freemarker.core.Expression.eval(Expression.java:101) [freemarker-2.3.32.jar:2.3.32]
at freemarker.core.DollarVariable.calculateInterpolatedStringOrMarkup(DollarVariable.java:104) [freemarker-2.3.32.jar:2.3.32]
at freemarker.core.DollarVariable.accept(DollarVariable.java:63) [freemarker-2.3.32.jar:2.3.32]
at freemarker.core.Environment.visit(Environment.java:335) [freemarker-2.3.32.jar:2.3.32]
at freemarker.core.Environment.visit(Environment.java:341) [freemarker-2.3.32.jar:2.3.32]
at freemarker.core.Environment.process(Environment.java:314) [freemarker-2.3.32.jar:2.3.32]
at org.apache.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:242) [main/:?]
at org.apache.ofbiz.widget.model.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:196) [main/:?]
at org.apache.ofbiz.widget.model.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:266) [main/:?]
at org.apache.ofbiz.widget.model.HtmlWidget.renderWidgetString(HtmlWidget.java:165) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreenWidget$PlatformSpecific.renderWidgetString(ModelScreenWidget.java:1371) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:158) [main/:?]
at org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:819) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:158) [main/:?]
at org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:900) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297) [main/:?]
at org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:158) [main/:?]
at org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:147) [main/:?]
at org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:105) [main/:?]
at org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:116) [main/:?]
at org.apache.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:1257) [main/:?]
at org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:933) [main/:?]
[...]
{noformat}
It seems rather related to this issue. I continue to test OFBIZ-12127
> Tidy up PDF accounting reports
> ------------------------------
>
> Key: OFBIZ-12778
> URL: https://issues.apache.org/jira/browse/OFBIZ-12778
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: 22.01.01
> Reporter: Daniel Watford
> Assignee: Daniel Watford
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: image-2023-03-14-17-41-27-646.png
>
>
> Various PDF report for the accounting app are poorly formatted and/or incorrectly list the type of transactions they contain.
> In the image below for a Transaction Totals report the Fiscal Type filter is showing all possible values, rather than the selected value 'Actual'.
> The Account Name column header is not formatted to match the other column headers.
> The Account Name column is too wide and leaves other columns without enough space, causing unnecessary wrapping and making the report more difficult to read.
> There is no padding around cell values, meaning text is in contact with the column divider lines.
> !image-2023-03-14-17-41-27-646.png!
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)