You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "AnonHxy (via GitHub)" <gi...@apache.org> on 2023/02/28 03:56:18 UTC
[GitHub] [pulsar] AnonHxy opened a new pull request, #19656: [improve][broker] Replace ScheduledExecutorService to ExecutorService in ModularLoadManagerImpl
AnonHxy opened a new pull request, #19656:
URL: https://github.com/apache/pulsar/pull/19656
### Motivation
An minor improvement by replacing `ScheduledExecutorService` to `ExecutorService` in ModularLoadManagerImpl
### Modifications
Replace ScheduledExecutorService to ExecutorService in ModularLoadManagerImpl
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #19656: [improve][broker] Replace ScheduledExecutorService to ExecutorService in ModularLoadManagerImpl
Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on PR #19656:
URL: https://github.com/apache/pulsar/pull/19656#issuecomment-1454358255
> @AnonHxy
>
> The PR is causing a test failure.
Thanks for your reminder. Fix it in this PR https://github.com/apache/pulsar/pull/19710 . PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy merged pull request #19656: [improve][broker] Replace ScheduledExecutorService to ExecutorService in ModularLoadManagerImpl
Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy merged PR #19656:
URL: https://github.com/apache/pulsar/pull/19656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker] Replace ScheduledExecutorService to ExecutorService in ModularLoadManagerImpl [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #19656:
URL: https://github.com/apache/pulsar/pull/19656#issuecomment-1979674944
Nevermind, cherry-picking and backporting #19710 to fix the issue in branch-2.11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19656: [improve][broker] Replace ScheduledExecutorService to ExecutorService in ModularLoadManagerImpl
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19656:
URL: https://github.com/apache/pulsar/pull/19656#issuecomment-1447536318
@AnonHxy Please add the following content to your PR description and select a checkbox:
```
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #19656: [improve][broker] Replace ScheduledExecutorService to ExecutorService in ModularLoadManagerImpl
Posted by "315157973 (via GitHub)" <gi...@apache.org>.
315157973 commented on PR #19656:
URL: https://github.com/apache/pulsar/pull/19656#issuecomment-1447639153
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker] Replace ScheduledExecutorService to ExecutorService in ModularLoadManagerImpl [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #19656:
URL: https://github.com/apache/pulsar/pull/19656#issuecomment-1979667112
Why was this cherry-picked to branch-2.11? The tests are broken in branch-2.11
```
Error: Tests run: 42, Failures: 1, Errors: 0, Skipped: 36, Time elapsed: 21.939 s <<< FAILURE! - in org.apache.pulsar.broker.namespace.NamespaceServiceTest
Error: testModularLoadManagerRemoveBundleAndLoad(org.apache.pulsar.broker.namespace.NamespaceServiceTest) Time elapsed: 2.615 s <<< FAILURE!
org.powermock.reflect.exceptions.FieldNotFoundException: No instance field named "scheduler" could be found in the class hierarchy of org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl.
at org.powermock.reflect.internal.matcherstrategies.FieldNameMatcherStrategy.notFound(FieldNameMatcherStrategy.java:40)
at org.powermock.reflect.internal.WhiteboxImpl.findSingleFieldUsingStrategy(WhiteboxImpl.java:502)
at org.powermock.reflect.internal.WhiteboxImpl.findFieldInHierarchy(WhiteboxImpl.java:455)
at org.powermock.reflect.internal.WhiteboxImpl.findFieldInHierarchy(WhiteboxImpl.java:443)
at org.powermock.reflect.internal.WhiteboxImpl.getInternalState(WhiteboxImpl.java:427)
at org.powermock.reflect.Whitebox.getInternalState(Whitebox.java:292)
at org.apache.pulsar.broker.namespace.NamespaceServiceTest.waitResourceDataUpdateToZK(NamespaceServiceTest.java:830)
at org.apache.pulsar.broker.namespace.NamespaceServiceTest.testModularLoadManagerRemoveBundleAndLoad(NamespaceServiceTest.java:789)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:840)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] heesung-sn commented on pull request #19656: [improve][broker] Replace ScheduledExecutorService to ExecutorService in ModularLoadManagerImpl
Posted by "heesung-sn (via GitHub)" <gi...@apache.org>.
heesung-sn commented on PR #19656:
URL: https://github.com/apache/pulsar/pull/19656#issuecomment-1454351762
@AnonHxy
The PR is causing a test failure.
https://github.com/apache/pulsar/pull/17487#issuecomment-1454347491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org