You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/03/24 21:22:08 UTC

Review Request 57923: Changed the agent's SecretGenerator from Owned to pointer.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57923/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-6999
    https://issues.apache.org/jira/browse/MESOS-6999


Repository: mesos


Description
-------

This patch updates the agent to hold its `SecretGenerator` as a
raw pointer instead of an `Owned` object. This is more consistent
with the other dependencies injected into the agent, and makes it
easier to test the agent with a mock secret generator.


Diffs
-----

  src/slave/slave.hpp e2de66cc5b899b8b9a9ea27cc30f19a9e8fc11fb 
  src/slave/slave.cpp a4f4a9ca80b726de8e07571fd6d93120947c278b 


Diff: https://reviews.apache.org/r/57923/diff/1/


Testing
-------

Testing details can be found at the end of this patch chain.


Thanks,

Greg Mann


Re: Review Request 57923: Changed the agent's SecretGenerator from Owned to pointer.

Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57923/#review170090
-----------------------------------------------------------


Ship it!




Ship It!

- Anand Mazumdar


On March 24, 2017, 9:50 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57923/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 9:50 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the agent to hold its `SecretGenerator` as a
> raw pointer instead of an `Owned` object. This is more consistent
> with the other dependencies injected into the agent, and makes it
> easier to test the agent with a mock secret generator.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp e2de66cc5b899b8b9a9ea27cc30f19a9e8fc11fb 
>   src/slave/slave.cpp a4f4a9ca80b726de8e07571fd6d93120947c278b 
> 
> 
> Diff: https://reviews.apache.org/r/57923/diff/2/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this patch chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 57923: Changed the agent's SecretGenerator from Owned to pointer.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57923/
-----------------------------------------------------------

(Updated March 24, 2017, 9:50 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
-------

Added nullptr initialization.


Bugs: MESOS-6999
    https://issues.apache.org/jira/browse/MESOS-6999


Repository: mesos


Description
-------

This patch updates the agent to hold its `SecretGenerator` as a
raw pointer instead of an `Owned` object. This is more consistent
with the other dependencies injected into the agent, and makes it
easier to test the agent with a mock secret generator.


Diffs (updated)
-----

  src/slave/slave.hpp e2de66cc5b899b8b9a9ea27cc30f19a9e8fc11fb 
  src/slave/slave.cpp a4f4a9ca80b726de8e07571fd6d93120947c278b 


Diff: https://reviews.apache.org/r/57923/diff/2/

Changes: https://reviews.apache.org/r/57923/diff/1-2/


Testing
-------

Testing details can be found at the end of this patch chain.


Thanks,

Greg Mann