You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/07/13 06:28:53 UTC

[GitHub] [shardingsphere] FlyingZC opened a new issue, #27068: Support parsing Oracle CREATE OR sql

FlyingZC opened a new issue, #27068:
URL: https://github.com/apache/shardingsphere/issues/27068

   # Background
   Hi community,
   This issue is for #26878.
   
   ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.
   
   More details:
   https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
   
   # Task
   This issue is to support more oracle sql parse, as follows:
   ```sql
   CREATE OR REPLACE TRIGGER Library_trigger
     INSTEAD OF
     INSERT ON Library_view
     FOR EACH ROW
   DECLARE
     Bookvar  Book_t;
     i        INTEGER;
   BEGIN
     INSERT INTO Library_table
     VALUES (:NEW.Section);
    
     FOR i IN 1..:NEW.Booklist.COUNT LOOP
       Bookvar := :NEW.Booklist(i);
    
       INSERT INTO Book_table (
         Booknum, Section, Title, Author, Available      
       )
       VALUES (
         Bookvar.booknum, :NEW.Section, Bookvar.Title,
         Bookvar.Author, bookvar.Available
       );
     END LOOP;
   END;
   ```
   
   ```sql
   CREATE OR REPLACE TRIGGER Tbl_Trg
     AFTER UPDATE ON tbl
     FOR EACH ROW
   BEGIN
     INSERT INTO tbl_history (d, old_obj, new_obj)
     VALUES (SYSDATE, :OLD.OBJECT_VALUE, :NEW.OBJECT_VALUE);
   END Tbl_Trg;
   ```
   
   ```sql
   CREATE OR REPLACE PACKAGE pkg IS
     n NUMBER := 5;
   END pkg;
   ```
   
   ```sql
   CREATE OR REPLACE TRIGGER Contacts_Rvrs_Xed
     BEFORE INSERT OR UPDATE ON Contacts_Table
     FOR EACH ROW
     REVERSE CROSSEDITION
     DISABLE
   BEGIN
     :NEW.Name_1 := :NEW.Last_Name_2||', '||:NEW.First_Name_2;
     :NEW.Phone_Number_1 :=
     CASE :New.Country_Code_2
       WHEN '+1' THEN
         REPLACE(:NEW.Phone_Number_2, '-', '.')
       ELSE
         '011.'||LTRIM(:NEW.Country_Code_2, '+')||'.'||
         REPLACE(:NEW.Phone_Number_2, '-', '.')
     END;
   END Contacts_Rvrs_Xed;
   ```
   
   ```sql
   CREATE OR REPLACE TRIGGER set_empno_ctx_trig AFTER LOGON ON DATABASE
    BEGIN
     sec_mgr.set_empno_ctx_proc;
    END;
   ```
   
   # Process
   1. First confirm that this is a correct oracle sql syntax, if not please ignore;
   2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
   3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
   4. Run mvn install the current_file_module;
   5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
   6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
   7. Run SQLParserParameterizedTest to make sure no exceptions.
   
   # Relevant Skills
   1. Master JAVA language
   2. Have a basic understanding of Antlr `g4` file
   3. Be familiar with Oracle SQLs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE OR sql [shardingsphere]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27068:
URL: https://github.com/apache/shardingsphere/issues/27068#issuecomment-1784213252

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] commented on issue #27068: Support parsing Oracle CREATE OR sql

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27068:
URL: https://github.com/apache/shardingsphere/issues/27068#issuecomment-1676080882

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle CREATE OR sql [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed issue #27068: Support parsing Oracle CREATE OR sql
URL: https://github.com/apache/shardingsphere/issues/27068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org