You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@myfaces.apache.org by cj...@apache.org on 2010/01/25 21:01:22 UTC

svn commit: r902961 - /myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/el/PropertyResolverImpl.java

Author: cjhoward
Date: Mon Jan 25 20:01:22 2010
New Revision: 902961

URL: http://svn.apache.org/viewvc?rev=902961&view=rev
Log:
MYFACES-2508 - setValue() must throw PNFE if property is read-only.

Modified:
    myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/el/PropertyResolverImpl.java

Modified: myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/el/PropertyResolverImpl.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/el/PropertyResolverImpl.java?rev=902961&r1=902960&r2=902961&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/el/PropertyResolverImpl.java (original)
+++ myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/el/PropertyResolverImpl.java Mon Jan 25 20:01:22 2010
@@ -71,7 +71,7 @@
     public void setValue(final Object base, final Object property, final Object newValue) throws EvaluationException,
         PropertyNotFoundException
     {
-        if (base == null || property == null)
+        if (base == null || property == null || isReadOnly (base, property))
             throw new PropertyNotFoundException();
 
         invokeResolver(new ResolverInvoker<Object>(base, property)