You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by an...@apache.org on 2017/11/27 18:59:07 UTC
[1/2] mesos git commit: Added Andrew Schwartzmeyer to the list of
committers.
Repository: mesos
Updated Branches:
refs/heads/master dfd1ee14a -> 6e80a393f
Added Andrew Schwartzmeyer to the list of committers.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/c5edc927
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/c5edc927
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/c5edc927
Branch: refs/heads/master
Commit: c5edc9276ed397fb9e32691f2068871c97fee620
Parents: dfd1ee1
Author: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Authored: Mon Nov 27 10:29:54 2017 -0800
Committer: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Committed: Mon Nov 27 10:29:54 2017 -0800
----------------------------------------------------------------------
docs/committers.md | 7 +++++++
1 file changed, 7 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/c5edc927/docs/committers.md
----------------------------------------------------------------------
diff --git a/docs/committers.md b/docs/committers.md
index b88426a..7b7369c 100644
--- a/docs/committers.md
+++ b/docs/committers.md
@@ -245,6 +245,13 @@ We'd like to thank the following committers to the Apache Mesos project who have
</tr>
<tr>
<td>-8</td>
+ <td>Andrew Schwartzmeyer</td>
+ <td>Microsoft</td>
+ <td>andschwa</td>
+ <td>andschwa@apache.org</td>
+ </tr>
+ <tr>
+ <td>-8</td>
<td>Gilbert Song</td>
<td>Mesosphere</td>
<td></td>
[2/2] mesos git commit: Added Windows to "don't break the build" note
in `committing.md`.
Posted by an...@apache.org.
Added Windows to "don't break the build" note in `committing.md`.
Also switched to Markdown supported numbered list so that it renders
correctly.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/6e80a393
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/6e80a393
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/6e80a393
Branch: refs/heads/master
Commit: 6e80a393f502164a90c490fe28c4368be55f0215
Parents: c5edc92
Author: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Authored: Mon Nov 27 10:35:57 2017 -0800
Committer: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Committed: Mon Nov 27 10:38:27 2017 -0800
----------------------------------------------------------------------
docs/committing.md | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/6e80a393/docs/committing.md
----------------------------------------------------------------------
diff --git a/docs/committing.md b/docs/committing.md
index 846210a..5a1b69c 100644
--- a/docs/committing.md
+++ b/docs/committing.md
@@ -14,21 +14,21 @@ If you are a committer, here are some guidelines for committing changes:
needed regarding the approach used in the patch.
2. **Follow the format of commit messages**: we currently do not leverage
any tooling to enforce the format of messages, so:
- a. Be clear and explicit in the commit message.
- b. Include the link to the review (this will be done automatically if
+ 1. Be clear and explicit in the commit message.
+ 2. Include the link to the review (this will be done automatically if
using `support/post-reviews.py` for your own changes and
`support/apply-review.sh` for committing changes from others).
**Be sure to clean up the commit message when pulling in changes
from others.**
- c. Use 72 character columns. Note that we don't always have a 50
+ 3. Use 72 character columns. Note that we don't always have a 50
character or less summary because that restriction tends to cause
people to write poorly.
3. **Keep the 'Author' intact**: `support/apply-review.sh` will handle
this for you, but be careful when rebasing or ammending.
4. **Never ever commit a merge**: always rebase instead, as appropriate.
Likewise, never 'force push'.
-5. **Don't break the build**: we support Linux and Mac OS X, however not
- all configurations are being tested in Jenkins, so be aware of that.
+5. **Don't break the build**: we support Linux, Mac OS X, and Windows. However,
+ not all configurations are being tested in Jenkins, so be aware of that.
Also, pay attention to the Jenkins review bot if it flags a review as
breaking the build. Note that if you do break the build, the fixes are
often small and inconsequential so don't worry about going through a