You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Chris Stylianou (JIRA)" <ji...@apache.org> on 2013/08/26 14:30:51 UTC

[jira] [Created] (THRIFT-2150) Should windows/config.h define WIN32_LEAN_AND_MEAN?

Chris Stylianou created THRIFT-2150:
---------------------------------------

             Summary: Should windows/config.h define WIN32_LEAN_AND_MEAN?
                 Key: THRIFT-2150
                 URL: https://issues.apache.org/jira/browse/THRIFT-2150
             Project: Thrift
          Issue Type: Improvement
          Components: C++ - Library
    Affects Versions: 0.9.1
         Environment: MSVC
            Reporter: Chris Stylianou


As "windows/config.h" includes Winsock2.h, is it not best practise to define before it: 
{code}WIN32_LEAN_AND_MEAN{code} 
This is in case someone includes Windows.h, which automatically includes the incompatible Winsock.h. It also reduces the size of the Win32 header files which helps compilation speeds :)


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira