[GitHub] [airflow] Taragolis commented on a diff in pull request #27786: Add operators + sensor for aws sagemaker pipelines

[GitBox <gi...@apache.org>]

Taragolis commented on code in PR #27786:
URL: https://github.com/apache/airflow/pull/27786#discussion_r1031764368


##########
airflow/providers/amazon/aws/hooks/sagemaker.py:
##########
@@ -647,28 +649,28 @@ def describe_endpoint(self, name: str) -> dict:
 
     def check_status(
         self,
-        job_name: str,
+        resource_name: str,

Review Comment:
   I just wondering is this changes could be classified as breaking changes or not?
   It is a small chance that user might use this public method in their code and define as arguments as keywords
   
   ```python
   SageMakerHook.check_status(
       job_name="foo-bar",
       key="spam",
       describe_function=some_callable
       check_interval=42
   )
   ```
   And after this changes their got:
   `TypeError: got an unexpected keyword argument 'job_name'`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org