You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/11/03 17:21:40 UTC
[GitHub] [commons-codec] Claudenw commented on a change in pull request #27:
Murmur3fix
Claudenw commented on a change in pull request #27: Murmur3fix
URL: https://github.com/apache/commons-codec/pull/27#discussion_r341862707
##########
File path: src/main/java/org/apache/commons/codec/digest/MurmurHash3.java
##########
@@ -393,7 +401,7 @@ public static long hash64(final byte[] data, final int offset, final int length,
* @return - 128 bit hash (2 longs)
*/
public static long[] hash128(final String data) {
- final byte[] origin = data.getBytes();
+ final byte[] origin = data.getBytes(StandardCharsets.UTF_8);
Review comment:
It showed up in a bug report -- reverting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services