You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Michael W Thelen <mi...@pietdepsi.com> on 2005/05/09 17:03:30 UTC

Re: [PATCH] Add Javahl method to stream content

Conor MacNeill wrote:
> This patch adds the ability to stream file content to a java
> OutputStream rather than reading the complete content into a byte array
> is is the case with the current fileContent methods. Requiring all of
> the content to be read into memory wont scale for larger files. The
> buffer size is passed in as part of the interface but this could be set
> within the code if desired and eliminated from the interface.

Thank you for the patch, I've filed it as issue #2299:
http://subversion.tigris.org/issues/show_bug.cgi?id=2299

> There's also a little bugfix included for the JNIEntry call in the
> fileContent method in org_tigris_subversion_javahl_SVNClient.cpp

Since it's a small bugfix that can be applied separately, you may want
to send it as a separate patch to the dev@ mailing list.

--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams