You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/12 10:06:08 UTC
[GitHub] [shardingsphere] lanchengx opened a new pull request, #17610: Adjust sharding rules to make table names insensitive.
lanchengx opened a new pull request, #17610:
URL: https://github.com/apache/shardingsphere/pull/17610
Fixes https://github.com/apache/shardingsphere/issues/17460
Changes proposed in this pull request:
- Adjust sharding rules to make table names insensitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #17610: Adjust sharding rules to make table names insensitive.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #17610:
URL: https://github.com/apache/shardingsphere/pull/17610#discussion_r871396400
##########
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-handler/src/main/java/org/apache/shardingsphere/sharding/distsql/handler/update/CreateShardingBindingTableRuleStatementUpdater.java:
##########
@@ -57,10 +57,15 @@ private void checkCurrentRuleConfiguration(final String databaseName, final Shar
private void checkToBeCreatedBindingTables(final String databaseName, final CreateShardingBindingTableRulesStatement sqlStatement,
final ShardingRuleConfiguration currentRuleConfig) throws DistSQLException {
Collection<String> currentLogicTables = getCurrentLogicTables(currentRuleConfig);
- Collection<String> notExistedBindingTables = sqlStatement.getBindingTables().stream().filter(each -> !currentLogicTables.contains(each)).collect(Collectors.toCollection(LinkedHashSet::new));
+ Collection<String> notExistedBindingTables = sqlStatement.getBindingTables().stream()
+ .filter(each -> !containsIgnoreCase(currentLogicTables, each)).collect(Collectors.toCollection(LinkedHashSet::new));
Review Comment:
Is `Collectors.toSet()` enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #17610: Adjust sharding rules to make table names insensitive.
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #17610:
URL: https://github.com/apache/shardingsphere/pull/17610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org