You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by DIPAYAN BHOWMICK <di...@gmail.com> on 2015/09/02 10:41:20 UTC

Review Request 38047: Fix Tez view to work with RM HA

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38047/
-----------------------------------------------------------

Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-12970
    https://issues.apache.org/jira/browse/AMBARI-12970


Repository: ambari


Description
-------

The code to fetch the RM Url has been refactored to use the Service Class in ambari-views-utils module.
Services class modified to also return the ATS server Url the logic is mostly similar to fetching the RM Url excepting connecting to the RM server(ATS server in this case)


Diffs
-----

  contrib/views/tez/pom.xml c7b9776 
  contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java df6b468 
  contrib/views/tez/src/main/resources/view.xml 91196fa 
  contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java 120e377 
  contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java 1950df8 

Diff: https://reviews.apache.org/r/38047/diff/


Testing
-------

Test case added for the ATS url. Ran the unit test cases. Locally tested in VMs.


Thanks,

DIPAYAN BHOWMICK

Re: Review Request 38047: Fix Tez view to work with RM HA

Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38047/#review97783
-----------------------------------------------------------

Ship it!


Ship It!

- Srimanth Gunturi


On Sept. 2, 2015, 8:41 a.m., DIPAYAN BHOWMICK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38047/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 8:41 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12970
>     https://issues.apache.org/jira/browse/AMBARI-12970
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The code to fetch the RM Url has been refactored to use the Service Class in ambari-views-utils module.
> Services class modified to also return the ATS server Url the logic is mostly similar to fetching the RM Url excepting connecting to the RM server(ATS server in this case)
> 
> 
> Diffs
> -----
> 
>   contrib/views/tez/pom.xml c7b9776 
>   contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java df6b468 
>   contrib/views/tez/src/main/resources/view.xml 91196fa 
>   contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java 120e377 
>   contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java 1950df8 
> 
> Diff: https://reviews.apache.org/r/38047/diff/
> 
> 
> Testing
> -------
> 
> Test case added for the ATS url. Ran the unit test cases. Locally tested in VMs.
> 
> 
> Thanks,
> 
> DIPAYAN BHOWMICK
> 
>