[GitHub] [flink] MartijnVisser commented on pull request #15140: [FLINK-20628][connectors/rabbitmq2] RabbitMQ connector using new connector API

[GitBox <gi...@apache.org>]

MartijnVisser commented on pull request #15140:
URL: https://github.com/apache/flink/pull/15140#issuecomment-1004761966


   @SteNicholas @RocMarshal I'm a bit hesitant to merge this PR because we are getting close to the release cut of Flink 1.15 and new connectors are quite often a source of flakiness. The CI doesn't check all use cases (like the Java 11 tests), so merging it could result in flakiness which I would rather avoid at this point. 
   
   I guess we could either postponing the merging of this PR until the release 1.15 branch has been cut (in a couple of weeks) or we could consider already moving this entire PR to its own external connector repo, as is the [current plan already](https://lists.apache.org/thread/bywh947r2f5hfocxq598zhyh06zhksrm). Something like github.com/apache/flink-connector-rabbitmq - We could use that repo to also test out the testing infrastructure that we need for external connector repositories anyway. 
   
   Let me know what you think. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org