You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Conny Kreyßel (JIRA)" <de...@db.apache.org> on 2006/08/23 12:54:13 UTC
[jira] Created: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Implement Bracketed SQL comments (/*...*/ comments)
---------------------------------------------------
Key: DERBY-1749
URL: http://issues.apache.org/jira/browse/DERBY-1749
Project: Derby
Issue Type: New Feature
Affects Versions: 10.1.3.1
Reporter: Conny Kreyßel
Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538591 ]
Dag H. Wanvik commented on DERBY-1749:
--------------------------------------
The patch is not sufficient: the standard demands that bracketed comments
can nest, cf. SQL 2003 section 5.2 <token> and <separator>, syntax rule 10):
"Within a <bracketed comment contents>, any <solidus> immediately followed by
an <asterisk> without any intervening <separator> shall be considered to be the
<bracketed comment introducer> of a <separator> that is a <bracketed comment>. "
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Assignee: Dag H. Wanvik
> Attachments: DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Thomas Nielsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Nielsen updated DERBY-1749:
----------------------------------
Affects Version/s: 10.2.2.0
10.3.1.4
Flagging most recent released versions as affected as well.
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik closed DERBY-1749.
--------------------------------
Did not hear back from reporter, so closing.
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Assignee: James F. Adams
> Fix For: 10.4.0.0
>
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, Derby-1749-4.diff, DERBY-1749.diff, releaseNote.html
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "James F. Adams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James F. Adams updated DERBY-1749:
----------------------------------
Attachment: Derby-1749-3.diff
Attached new patch (Derby-1749-3.diff) that adds some simple bracketed comment tests.
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-rrefsqlj28468.html.diff, Derby-1749-2.txt, Derby-1749-3.diff, DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543083 ]
Dag H. Wanvik commented on DERBY-1749:
--------------------------------------
Assigned this to you James, since you did most of the work.
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Assignee: James F. Adams
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, Derby-1749-4.diff, DERBY-1749.diff, releaseNote.html
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Thomas Nielsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Nielsen updated DERBY-1749:
----------------------------------
Attachment: d1749-rrefsqlj28468.dita.diff
d1749-rrefsqlj28468.html.diff-2
d1749-ref-single.html.diff-2
Updated dita source and html attached. This includes a comment on nested bracketed comments. Thanks for spotting that Dag.
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik reassigned DERBY-1749:
------------------------------------
Assignee: Dag H. Wanvik
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Assignee: Dag H. Wanvik
> Attachments: DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-1749:
---------------------------------
Assignee: (was: Dag H. Wanvik)
Unassiging myself for now.
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543082 ]
Dag H. Wanvik commented on DERBY-1749:
--------------------------------------
Committed Derby-1749-4.diff as svn 595662.
Thanks for the good work, James!
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, Derby-1749-4.diff, DERBY-1749.diff, releaseNote.html
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik reassigned DERBY-1749:
------------------------------------
Assignee: James F. Adams
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Assignee: James F. Adams
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, Derby-1749-4.diff, DERBY-1749.diff, releaseNote.html
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542833 ]
Dag H. Wanvik commented on DERBY-1749:
--------------------------------------
Thomas, would you be willing to write and attach the release notes for this feature also?
Template can be found here:
../tools/release/templates/releaseNote.html
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542417 ]
Dag H. Wanvik commented on DERBY-1749:
--------------------------------------
Patch looks good, James, thanks! Do you plan to add tests also?
Thomas, thanks for the doc updates.
The description should mention that bracketed comments nest.
Could you make the changes to the .dita files also?
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-rrefsqlj28468.html.diff, Derby-1749-2.txt, DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "James F. Adams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James F. Adams updated DERBY-1749:
----------------------------------
Derby Info: [Patch Available]
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-rrefsqlj28468.html.diff, Derby-1749-2.txt, Derby-1749-3.diff, DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542832 ]
Dag H. Wanvik commented on DERBY-1749:
--------------------------------------
Thanks for making tests, too, James!
The tests look good and passed in my sandbox.
I will add some with a mix of eol("---") and bracketed comments for
good measure.
And Thomas, thanks for the doc patch, I generated the docs
with it and it looks good.
I will probably substitute "asterisk" for "star" to keep
in line with typography language.
I will commit both when my regression tests are done.
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-1749:
---------------------------------
Attachment: DERBY-1749.diff
Here is a patch for sqlgrammar.jj which implements bracketed comments
Not a complete patch; no tests added yet, running regression
tests now.
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Thomas Nielsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542843 ]
Thomas Nielsen commented on DERBY-1749:
---------------------------------------
+1 for the asterisk change Dag.
Sure, I'll do a releaseNote for this issue .
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-1749:
---------------------------------
Fix Version/s: 10.4.0.0
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Assignee: James F. Adams
> Fix For: 10.4.0.0
>
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, Derby-1749-4.diff, DERBY-1749.diff, releaseNote.html
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-1749:
---------------------------------
Derby Info: [Patch Available, Release Note Needed] (was: [Patch Available])
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Thomas Nielsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537519 ]
Thomas Nielsen commented on DERBY-1749:
---------------------------------------
Workaround details missing from orginal report:
Change the "sql_comments" flag in the Hibernate configfile to disable comments in the generated sql.
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Conny Kreyßel
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Thomas Nielsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Nielsen updated DERBY-1749:
----------------------------------
Attachment: releaseNote.html
Attaching releaseNote.html
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, DERBY-1749.diff, releaseNote.html
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by Daniel John Debrunner <dj...@apache.org>.
Dag H. Wanvik wrote:
> Finally, the relase notes also provides a convenient place to give a
> short introduction to new features (pointers to doc if nothing
> else). Could not that justify the inclusion even if there is no impact
> on existing apps?
The trouble is that the releaseNote template is geared towards issues
that change existing behaviour, not those that introduce new. The
release note for DERBY-1749 is somewhat awkward for exactly this reason.
Dan.
Re: [jira] Commented: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik" <Da...@Sun.COM>.
"Daniel John Debrunner (JIRA)" <ji...@apache.org> writes:
> Dag, could you explain why a release note is needed. I thought
> release notes were for changes that might affect existing working
> applications, I didn't think new features had release notes?
Thanks for addressing this, Dan. I admit I am slightly unclear on this,
so I did some digging.
For bracketed comments, I agree it is more reasonable to list the JIRA
in the "features" section of the relase notes, also since bracketed
comments have a SQL feature number; Optional Feature T352. The JIRA is
marked as a New Feature in JIRA so finding it for the release manager
when preparing the relase notes is not an issue.
We have the Wiki for "big" features listed here:
http://wiki.apache.org/db-derby/DerbyTenFourRelease?highlight=%28tenfour%29
In the 10.3 release notes I see:
"Compared with the previous release (10.2.2.0), Derby release
10.3.1.4 introduces the following new features and
incompatibilities. These merit your special attention."
and then proceeds to list the release notes generated from JIRAs.
Maybe it should read "new features and improvements which may have
impact on existing applications and bugs"?
In http://wiki.apache.org/db-derby/ReleaseNoteProcess, we describe the
release note process, but that page doesn't give any advise as to when
a release note is needed. It uses the phrase "releaseNotes.html files
which were attached to significant JIRAs".
Btw, we also have a JIRA flag for "affects existing applications" - is
the "release note needed" flag redundant, then? Should all JIRAs whose
inclusion "affects existing applications" also have a
releaseNote.html, or only the "significant" ones?
http://wiki.apache.org/db-derby/DerbySnapshotOrRelease?highlight=%28existing%29%7C%28application%29
says that releaseNotes.html is expected to be found "marked with
'Existing Application Impact' or 'Release Note Needed'" (if fixed and
new is this release).
I could not find any description of/guidance on these flags in
http://db.apache.org/derby/binaries/FilingDerbyIssuesInJira.doc
Finally, the relase notes also provides a convenient place to give a
short introduction to new features (pointers to doc if nothing
else). Could not that justify the inclusion even if there is no impact
on existing apps?
Dag
Re: [jira] Commented: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by Øystein Grøvlen <Oy...@Sun.COM>.
Daniel John Debrunner (JIRA) wrote:
> Dag, could you explain why a release note is needed. I thought release notes were for changes that might affect existing working applications, I didn't think new features had release notes?
At least, new features should be mentioned in the list of new features
in the release note. I guess the best way to ensure that is to add it
to the list of new features on the wiki page for the next feature release.
--
Øyst
[jira] Commented: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542862 ]
Daniel John Debrunner commented on DERBY-1749:
----------------------------------------------
Dag, could you explain why a release note is needed. I thought release notes were for changes that might affect existing working applications, I didn't think new features had release notes?
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, DERBY-1749.diff, releaseNote.html
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "James F. Adams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James F. Adams updated DERBY-1749:
----------------------------------
Attachment: Derby-1749-2.txt
Derby-1749-2 is an updated patch to sqlgrammar.jj which implements nested bracketed comments.
Not a complete patch; no tests added yet.
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: Derby-1749-2.txt, DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543079 ]
Dag H. Wanvik commented on DERBY-1749:
--------------------------------------
The releaseNotes.html is probably redundant here, see discussion
in http://www.nabble.com/-jira--Created%3A-%28DERBY-1749%29-Implement-Bracketed-SQL-comments-%28-*...*--comments%29-t2151720i20.html
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, DERBY-1749.diff, releaseNote.html
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Thomas Nielsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Nielsen updated DERBY-1749:
----------------------------------
Attachment: d1749-rrefsqlj28468.html.diff
d1749-ref-single.html.diff
Attaching proposal for updated comments text for the Reference Guide under "Capitalization and special characters".
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-rrefsqlj28468.html.diff, Derby-1749-2.txt, DERBY-1749.diff
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-1749:
---------------------------------
Attachment: Derby-1749-4.diff
Same as Derby-1749-3.diff, but adds a few new test cases.
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, Derby-1749-4.diff, DERBY-1749.diff, releaseNote.html
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik resolved DERBY-1749.
----------------------------------
Resolution: Fixed
Derby Info: (was: [Release Note Needed, Patch Available])
Committed patch d1749-rrefsqlj28468.dita.diff to the documentation trunk
as svn 595671. Thanks Thomas!
Removing release note needed flag as per the discussion we had, see previous comments.
Resolving.
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6, 10.2.2.0, 10.3.1.4
> Reporter: Conny Kreyßel
> Assignee: James F. Adams
> Attachments: d1749-ref-single.html.diff, d1749-ref-single.html.diff-2, d1749-rrefsqlj28468.dita.diff, d1749-rrefsqlj28468.html.diff, d1749-rrefsqlj28468.html.diff-2, Derby-1749-2.txt, Derby-1749-3.diff, Derby-1749-4.diff, DERBY-1749.diff, releaseNote.html
>
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1749) Implement Bracketed SQL comments
(/*...*/ comments)
Posted by "Andrew McIntyre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew McIntyre updated DERBY-1749:
-----------------------------------
Component/s: SQL
> Implement Bracketed SQL comments (/*...*/ comments)
> ---------------------------------------------------
>
> Key: DERBY-1749
> URL: https://issues.apache.org/jira/browse/DERBY-1749
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Conny Kreyßel
>
> Hibernate use multiline sql statements to show the internal building of the hql statements. You can disable this feature, but it would be nice if you can implements bracketed SQL comments in Derby.
> Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira