You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/23 05:09:31 UTC

[GitHub] [apisix-dashboard] idbeta opened a new issue #852: bug: manager-api supported `POST` method for consumer

idbeta opened a new issue #852:
URL: https://github.com/apache/apisix-dashboard/issues/852


   # Bug report
   
   ## Describe the bug
   manager-api supported `POST` method for consumer.
   but it should not support the post method for consumer, the same as adminapi.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz commented on issue #852: bug: manager-api supported `POST` method for consumer

Posted by GitBox <gi...@apache.org>.
starsz commented on issue #852:
URL: https://github.com/apache/apisix-dashboard/issues/852#issuecomment-732168246


   Hi, @idbeta. It's easy to fix, you can assign it to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz commented on issue #852: bug: manager-api supported `POST` method for consumer

Posted by GitBox <gi...@apache.org>.
starsz commented on issue #852:
URL: https://github.com/apache/apisix-dashboard/issues/852#issuecomment-732637307


   > > So I think apisix-dashboard should forbid `POST` and merge `Create and Update` into a function which was called by`PUT` method.
   > 
   > agree with this. @starsz would like to fix this issue?
   
   My pleasure, please assign to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz edited a comment on issue #852: bug: manager-api supported `POST` method for consumer

Posted by GitBox <gi...@apache.org>.
starsz edited a comment on issue #852:
URL: https://github.com/apache/apisix-dashboard/issues/852#issuecomment-732168246


   Hi, @idbeta. I had lookup the code in apisix-dashboard and apisix.
   
   apisix will return  405 and `not supported `POST` method for consumer`
   apisix-dashboard will create a new consumer.
   
   So I think apisix-dashboard should forbid `POST` and merge `Create and Update` into a function which was called by `PUT`.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] membphis commented on issue #852: bug: manager-api supported `POST` method for consumer

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #852:
URL: https://github.com/apache/apisix-dashboard/issues/852#issuecomment-732628199


   > So I think apisix-dashboard should forbid `POST` and merge `Create and Update` into a function which was called by`PUT` method.
   
   agree with this. @starsz would like to fix this issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #852: bug: manager-api supported `POST` method for consumer

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #852:
URL: https://github.com/apache/apisix-dashboard/issues/852#issuecomment-732223115


   The frontend will use put instead of post now. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz edited a comment on issue #852: bug: manager-api supported `POST` method for consumer

Posted by GitBox <gi...@apache.org>.
starsz edited a comment on issue #852:
URL: https://github.com/apache/apisix-dashboard/issues/852#issuecomment-732168246


   Hi, @idbeta. I had lookup the code in apisix-dashboard and apisix.
   
   apisix will return  405 and `not supported POST method for consumer`
   apisix-dashboard will create a new consumer.
   
   So I think apisix-dashboard should forbid `POST` and merge `Create and Update` into a function which was called by`PUT` method.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] membphis closed issue #852: bug: manager-api supported `POST` method for consumer

Posted by GitBox <gi...@apache.org>.
membphis closed issue #852:
URL: https://github.com/apache/apisix-dashboard/issues/852


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz edited a comment on issue #852: bug: manager-api supported `POST` method for consumer

Posted by GitBox <gi...@apache.org>.
starsz edited a comment on issue #852:
URL: https://github.com/apache/apisix-dashboard/issues/852#issuecomment-732168246






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] tokers closed issue #852: bug: manager-api supported `POST` method for consumer

Posted by GitBox <gi...@apache.org>.
tokers closed issue #852:
URL: https://github.com/apache/apisix-dashboard/issues/852


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org