You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/10/30 22:47:45 UTC
Review Request 63432: Updated the comment about slaves.removed in
master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63432/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
Repository: mesos
Description
-------
Updated the comment about slaves.removed in master.
Diffs
-----
src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3
Diff: https://reviews.apache.org/r/63432/diff/1/
Testing
-------
trivial
Thanks,
Jie Yu
Re: Review Request 63432: Updated the comment about slaves.removed in
master.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63432/#review189698
-----------------------------------------------------------
PASS: Mesos patch 63432 was successfully built and tested.
Reviews applied: `['63432']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63432
- Mesos Reviewbot Windows
On Oct. 30, 2017, 10:47 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63432/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 10:47 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the comment about slaves.removed in master.
>
>
> Diffs
> -----
>
> src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3
>
>
> Diff: https://reviews.apache.org/r/63432/diff/1/
>
>
> Testing
> -------
>
> trivial
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 63432: Updated the comment about slaves.removed in
master.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63432/#review189696
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63432]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 30, 2017, 10:47 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63432/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 10:47 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the comment about slaves.removed in master.
>
>
> Diffs
> -----
>
> src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3
>
>
> Diff: https://reviews.apache.org/r/63432/diff/1/
>
>
> Testing
> -------
>
> trivial
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 63432: Updated the comment about slaves.removed in
master.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63432/#review189666
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Oct. 30, 2017, 10:47 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63432/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 10:47 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the comment about slaves.removed in master.
>
>
> Diffs
> -----
>
> src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3
>
>
> Diff: https://reviews.apache.org/r/63432/diff/1/
>
>
> Testing
> -------
>
> trivial
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 63432: Updated the comment about slaves.removed in
master.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63432/
-----------------------------------------------------------
(Updated Nov. 6, 2017, 10:43 p.m.)
Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
Bugs: MESOS-7235
https://issues.apache.org/jira/browse/MESOS-7235
Repository: mesos
Description
-------
Updated the comment about slaves.removed in master.
Diffs
-----
src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3
Diff: https://reviews.apache.org/r/63432/diff/2/
Testing
-------
trivial
Thanks,
Jie Yu
Re: Review Request 63432: Updated the comment about slaves.removed in
master.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63432/
-----------------------------------------------------------
(Updated Nov. 1, 2017, 11:14 p.m.)
Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Updated the comment about slaves.removed in master.
Diffs (updated)
-----
src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3
Diff: https://reviews.apache.org/r/63432/diff/2/
Changes: https://reviews.apache.org/r/63432/diff/1-2/
Testing
-------
trivial
Thanks,
Jie Yu