You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/15 19:34:25 UTC
[GitHub] [spark] rdblue commented on a change in pull request #34497: [SPARK-37219][SQL] Add AS OF syntax support
rdblue commented on a change in pull request #34497:
URL: https://github.com/apache/spark/pull/34497#discussion_r749623829
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -598,6 +598,13 @@ fromClause
: FROM relation (',' relation)* lateralView* pivotClause?
;
+temporalClause
+ : VERSION AS OF version=INTEGER_VALUE
+ | FOR SYSTEM_VERSION AS OF version=INTEGER_VALUE
Review comment:
I agree. Shouldn't all of these be strings or even more generic so that the user can pass whatever is a version in a particular storage layer? HBase would use a long, but versions could easily be a UUID or some other type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org