You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/03 07:05:28 UTC

[GitHub] [spark] techaddict opened a new pull request, #39359: [SPARK-41857][CONNECT][TESTS] Enable test_between_function, test_datetime_functions, test_expr, test_function_parity, test_math_functions, test_window_functions_cumulative_sum, test_corr, test_cov, test_crosstab, test_approxQuantile

techaddict opened a new pull request, #39359:
URL: https://github.com/apache/spark/pull/39359

   ### What changes were proposed in this pull request?
   This PR enables the reused PySpark tests in Spark Connect that pass now.
   
   ### Why are the changes needed?
   To make sure on the test coverage.
   
   ### Does this PR introduce any user-facing change?
   No, test-only.
   
   ### How was this patch tested?
   Enabling tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #39359: [SPARK-41857][CONNECT][TESTS] Enable test_between_function, test_datetime_functions, test_expr, test_math_functions, test_window_functions_cumulative_sum, test_corr, test_cov, test_crosstab, test_approxQuantile

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39359: [SPARK-41857][CONNECT][TESTS] Enable test_between_function, test_datetime_functions, test_expr, test_math_functions, test_window_functions_cumulative_sum, test_corr, test_cov, test_crosstab, test_approxQuantile
URL: https://github.com/apache/spark/pull/39359


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #39359: [SPARK-41857][CONNECT][TESTS] Enable test_between_function, test_datetime_functions, test_expr, test_math_functions, test_window_functions_cumulative_sum, test_corr, test_cov, test_crosstab, test_approxQuantile

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39359:
URL: https://github.com/apache/spark/pull/39359#issuecomment-1369512360

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39359: [SPARK-41857][CONNECT][TESTS] Enable test_between_function, test_datetime_functions, test_expr, test_function_parity, test_math_functions, test_window_functions_cumulative_sum, test_corr, test_cov, test_crosstab, test_approxQuantile

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #39359:
URL: https://github.com/apache/spark/pull/39359#discussion_r1060328405


##########
python/pyspark/sql/tests/connect/test_parity_functions.py:
##########
@@ -84,18 +76,10 @@ def test_dayofweek(self):
     def test_explode(self):
         super().test_explode()
 
-    @unittest.skip("Fails in Spark Connect, should enable.")
-    def test_expr(self):
-        super().test_expr()
-
     @unittest.skip("Fails in Spark Connect, should enable.")
     def test_first_last_ignorenulls(self):
         super().test_first_last_ignorenulls()
 
-    @unittest.skip("Fails in Spark Connect, should enable.")

Review Comment:
   Let's skip this one. This one requires to use `self.sc`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org